[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20251009142955.562032-1-i.abramov@mt-integration.ru>
Date: Thu, 9 Oct 2025 17:29:54 +0300
From: Ivan Abramov <i.abramov@...integration.ru>
To: Sebastian Reichel <sre@...nel.org>
CC: Ivan Abramov <i.abramov@...integration.ru>, Mark Brown
<broonie@...nel.org>, Lee Jones <lee@...nel.org>, Felipe Balbi
<felipe.balbi@...ux.intel.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>,
<linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<lvc-project@...uxtesting.org>
Subject: [PATCH 1/1] power: supply: rt9467: Return error on failure in rt9467_set_value_from_ranges()
The return value of rt9467_set_value_from_ranges() when setting AICL VTH is
not checked, even though it may fail.
Log error and return from rt9467_run_aicl() on fail.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 626b6cd5f52e ("power: wm831x_power: Support USB charger current limit management")
Signed-off-by: Ivan Abramov <i.abramov@...integration.ru>
---
drivers/power/supply/rt9467-charger.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/power/supply/rt9467-charger.c b/drivers/power/supply/rt9467-charger.c
index fe773dd8b404..b4917514bd70 100644
--- a/drivers/power/supply/rt9467-charger.c
+++ b/drivers/power/supply/rt9467-charger.c
@@ -588,6 +588,10 @@ static int rt9467_run_aicl(struct rt9467_chg_data *data)
aicl_vth = mivr_vth + RT9467_AICLVTH_GAP_uV;
ret = rt9467_set_value_from_ranges(data, F_AICL_VTH,
RT9467_RANGE_AICL_VTH, aicl_vth);
+ if (ret) {
+ dev_err(data->dev, "Failed to set AICL VTH\n");
+ return ret;
+ }
/* Trigger AICL function */
ret = regmap_field_write(data->rm_field[F_AICL_MEAS], 1);
--
2.39.5
Powered by blists - more mailing lists