[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20251009145308.1830893-1-m.masimov@mt-integration.ru>
Date: Thu, 9 Oct 2025 17:53:08 +0300
From: Murad Masimov <m.masimov@...integration.ru>
To: Sebastian Reichel <sre@...nel.org>
CC: ChiYuan Huang <cy_huang@...htek.com>, ChiaEn Wu <chiaen_wu@...htek.com>,
<linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<lvc-project@...uxtesting.org>, Murad Masimov <m.masimov@...integration.ru>
Subject: [PATCH] power: supply: rt9467: Prevent using uninitialized local variable in rt9467_set_value_from_ranges()
There is a typo in rt9467_set_value_from_ranges() that can cause leaving local
variable sel with an undefined value which is then used in regmap_field_write().
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 6f7f70e3a8dd ("power: supply: rt9467: Add Richtek RT9467 charger driver")
Signed-off-by: Murad Masimov <m.masimov@...integration.ru>
---
drivers/power/supply/rt9467-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/rt9467-charger.c b/drivers/power/supply/rt9467-charger.c
index fe773dd8b404..ee311c0af7f7 100644
--- a/drivers/power/supply/rt9467-charger.c
+++ b/drivers/power/supply/rt9467-charger.c
@@ -376,7 +376,7 @@ static int rt9467_set_value_from_ranges(struct rt9467_chg_data *data,
if (rsel == RT9467_RANGE_VMIVR) {
ret = linear_range_get_selector_high(range, value, &sel, &found);
if (ret)
- value = range->max_sel;
+ sel = range->max_sel;
} else {
linear_range_get_selector_within(range, value, &sel);
}
--
2.39.2
Powered by blists - more mailing lists