linux-kernel - Re: [PATCH v5 03/10] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cae78078-e8f8-402c-a9f5-f9a9731e4a0a@kernel.org>
Date: Sat, 11 Oct 2025 02:01:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wesley Cheng <wesley.cheng@....qualcomm.com>, krzk+dt@...nel.org,
 conor+dt@...nel.org, konrad.dybcio@....qualcomm.com,
 dmitry.baryshkov@....qualcomm.com, kishon@...nel.org, vkoul@...nel.org,
 gregkh@...uxfoundation.org, robh@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
 linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 03/10] dt-bindings: phy: qcom-m31-eusb2: Add Glymur
 compatible

On 07/10/2025 00:19, Wesley Cheng wrote:
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: qcom,sm8750-m31-eusb2-phy
> +    then:
> +      required:
> +        - clocks
> +        - clock-names

Nothing in commit msg explains why the new phy can run magically without
any clock. Seems unlikely, hardware does not work like that, so this
seems wrong.


Also, don't combine USB patches into other subsystems. I already asked
about this qcom few times.

Best regards,
Krzysztof