linux-kernel - Re: [PATCH 16/16] media: rockchip: rga: add rga3 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202510111354.QeqIltfU-lkp@intel.com>
Date: Sat, 11 Oct 2025 13:32:51 +0800
From: kernel test robot <lkp@...el.com>
To: Sven Püschel <s.pueschel@...gutronix.de>,
	Jacob Chen <jacob-chen@...wrt.com>,
	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, kernel@...gutronix.de,
	Sven Püschel <s.pueschel@...gutronix.de>
Subject: Re: [PATCH 16/16] media: rockchip: rga: add rga3 support

Hi Sven,

kernel test robot noticed the following build warnings:

[auto build test WARNING on afb100a5ea7a13d7e6937dcd3b36b19dc6cc9328]

url:    https://github.com/intel-lab-lkp/linux/commits/Sven-P-schel/media-rockchip-rga-use-clk_bulk-api/20251010-104411
base:   afb100a5ea7a13d7e6937dcd3b36b19dc6cc9328
patch link:    https://lore.kernel.org/r/20251007-spu-rga3-v1-16-36ad85570402%40pengutronix.de
patch subject: [PATCH 16/16] media: rockchip: rga: add rga3 support
config: riscv-randconfig-002-20251011 (https://download.01.org/0day-ci/archive/20251011/202510111354.QeqIltfU-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 39f292ffa13d7ca0d1edff27ac8fd55024bb4d19)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251011/202510111354.QeqIltfU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510111354.QeqIltfU-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/media/platform/rockchip/rga/rga3-hw.c:144:15: warning: variable 'src_h' set but not used [-Wunused-but-set-variable]
     144 |         unsigned int src_h, src_w, dst_h, dst_w;
         |                      ^
>> drivers/media/platform/rockchip/rga/rga3-hw.c:144:22: warning: variable 'src_w' set but not used [-Wunused-but-set-variable]
     144 |         unsigned int src_h, src_w, dst_h, dst_w;
         |                             ^
>> drivers/media/platform/rockchip/rga/rga3-hw.c:144:29: warning: variable 'dst_h' set but not used [-Wunused-but-set-variable]
     144 |         unsigned int src_h, src_w, dst_h, dst_w;
         |                                    ^
>> drivers/media/platform/rockchip/rga/rga3-hw.c:144:36: warning: variable 'dst_w' set but not used [-Wunused-but-set-variable]
     144 |         unsigned int src_h, src_w, dst_h, dst_w;
         |                                           ^
   4 warnings generated.


vim +/src_h +144 drivers/media/platform/rockchip/rga/rga3-hw.c

   137	
   138	static void rga3_cmd_set_win0_format(struct rga_ctx *ctx)
   139	{
   140		u32 *cmd = ctx->rga->cmdbuf_virt;
   141		const struct rga3_fmt *in = ctx->in.fmt;
   142		const struct rga3_fmt *out = ctx->out.fmt;
   143		const struct v4l2_format_info *in_fmt, *out_fmt;
 > 144		unsigned int src_h, src_w, dst_h, dst_w;
   145		bool r2y, y2r;
   146		u8 rd_format;
   147		unsigned int reg;
   148	
   149		src_h = ctx->in.crop.height;
   150		src_w = ctx->in.crop.width;
   151		dst_h = ctx->out.crop.height;
   152		dst_w = ctx->out.crop.width;
   153	
   154		in_fmt = v4l2_format_info(in->fourcc);
   155		out_fmt = v4l2_format_info(out->fourcc);
   156		r2y = v4l2_is_format_rgb(in_fmt) && v4l2_is_format_yuv(out_fmt);
   157		y2r = v4l2_is_format_yuv(in_fmt) && v4l2_is_format_rgb(out_fmt);
   158	
   159		if (in->semi_planar)
   160			rd_format = RGA3_RDWR_FORMAT_SEMI_PLANAR;
   161		else
   162			rd_format = RGA3_RDWR_FORMAT_INTERLEAVED;
   163	
   164		reg = RGA3_WIN0_RD_CTRL - RGA3_FIRST_CMD_REG;
   165		cmd[reg >> 2] |= FIELD_PREP(RGA3_WIN_PIC_FORMAT, in->hw_format)
   166			      |  FIELD_PREP(RGA3_WIN_YC_SWAP, in->yc_swap)
   167			      |  FIELD_PREP(RGA3_WIN_RBUV_SWAP, in->rbuv_swap)
   168			      |  FIELD_PREP(RGA3_WIN_RD_FORMAT, rd_format)
   169			      |  FIELD_PREP(RGA3_WIN_R2Y, r2y)
   170			      |  FIELD_PREP(RGA3_WIN_Y2R, y2r)
   171			      |  FIELD_PREP(RGA3_WIN_CSC_MODE, RGA3_WIN_CSC_MODE_BT601_F);
   172	}
   173	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki