linux-kernel - Re: [PATCH v5 2/2] irqchip/irq-loongarch-ir:Add Redirect irqchip support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202510112232.3mPdCFd1-lkp@intel.com>
Date: Sat, 11 Oct 2025 23:27:14 +0800
From: kernel test robot <lkp@...el.com>
To: Tianyang Zhang <zhangtianyang@...ngson.cn>, chenhuacai@...nel.org,
	kernel@...0n.name, corbet@....net, alexs@...nel.org,
	si.yanteng@...ux.dev, tglx@...utronix.de, jiaxun.yang@...goat.com,
	peterz@...radead.org, wangliupu@...ngson.cn, lvjianmin@...ngson.cn,
	maobibo@...ngson.cn, siyanteng@...oftware.com.cn,
	gaosong@...ngson.cn, yangtiezhu@...ngson.cn
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	loongarch@...ts.linux.dev, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Tianyang Zhang <zhangtianyang@...ngson.cn>
Subject: Re: [PATCH v5 2/2] irqchip/irq-loongarch-ir:Add Redirect irqchip
 support

Hi Tianyang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/irq/core]
[also build test WARNING on linus/master v6.17 next-20251010]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tianyang-Zhang/Docs-LoongArch-Add-Advanced-Extended-Redirect-IRQ-model-description/20251010-131542
base:   tip/irq/core
patch link:    https://lore.kernel.org/r/20251010022845.140234-3-zhangtianyang%40loongson.cn
patch subject: [PATCH v5 2/2] irqchip/irq-loongarch-ir:Add Redirect irqchip support
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20251011/202510112232.3mPdCFd1-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251011/202510112232.3mPdCFd1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510112232.3mPdCFd1-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/irqchip/irq-loongarch-ir.c:498:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
     498 |         if (!redirect_domain) {
         |             ^~~~~~~~~~~~~~~~
   drivers/irqchip/irq-loongarch-ir.c:525:9: note: uninitialized use occurs here
     525 |         return ret;
         |                ^~~
   drivers/irqchip/irq-loongarch-ir.c:498:2: note: remove the 'if' if its condition is always false
     498 |         if (!redirect_domain) {
         |         ^~~~~~~~~~~~~~~~~~~~~~~
     499 |                 pr_err("Unable to alloc redirect domain\n");
         |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     500 |                 goto out_free_fwnode;
         |                 ~~~~~~~~~~~~~~~~~~~~~
     501 |         }
         |         ~
   drivers/irqchip/irq-loongarch-ir.c:491:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
     491 |         if (!fwnode) {
         |             ^~~~~~~
   drivers/irqchip/irq-loongarch-ir.c:525:9: note: uninitialized use occurs here
     525 |         return ret;
         |                ^~~
   drivers/irqchip/irq-loongarch-ir.c:491:2: note: remove the 'if' if its condition is always false
     491 |         if (!fwnode) {
         |         ^~~~~~~~~~~~~~
     492 |                 pr_err("Unable to alloc redirect domain handle\n");
         |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     493 |                 goto fail;
         |                 ~~~~~~~~~~
     494 |         }
         |         ~
   drivers/irqchip/irq-loongarch-ir.c:488:9: note: initialize the variable 'ret' to silence this warning
     488 |         int ret, node;
         |                ^
         |                 = 0
   2 warnings generated.


vim +498 drivers/irqchip/irq-loongarch-ir.c

   484	
   485	int __init redirect_acpi_init(struct irq_domain *parent)
   486	{
   487		struct fwnode_handle *fwnode;
   488		int ret, node;
   489	
   490		fwnode = irq_domain_alloc_named_fwnode("redirect");
   491		if (!fwnode) {
   492			pr_err("Unable to alloc redirect domain handle\n");
   493			goto fail;
   494		}
   495	
   496		redirect_domain = irq_domain_create_hierarchy(parent, 0, IRD_ENTRIES, fwnode,
   497							      &redirect_domain_ops, irde_descs);
 > 498		if (!redirect_domain) {

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki