linux-kernel - Re: [PATCH v2 2/2] firmware: imx: sm-misc: Dump syslog info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202510120607.1JmlmOTI-lkp@intel.com>
Date: Sun, 12 Oct 2025 06:52:31 +0800
From: kernel test robot <lkp@...el.com>
To: Peng Fan <peng.fan@....com>, Sudeep Holla <sudeep.holla@....com>,
	Cristian Marussi <cristian.marussi@....com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Dan Carpenter <error27@...il.com>, Frank Li <frank.li@....com>,
	arm-scmi@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Peng Fan <peng.fan@....com>
Subject: Re: [PATCH v2 2/2] firmware: imx: sm-misc: Dump syslog info

Hi Peng,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 2b763d4652393c90eaa771a5164502ec9dd965ae]

url:    https://github.com/intel-lab-lkp/linux/commits/Peng-Fan/firmware-arm_scmi-imx-Support-getting-syslog-of-MISC-protocol/20251011-193459
base:   2b763d4652393c90eaa771a5164502ec9dd965ae
patch link:    https://lore.kernel.org/r/20251011-sm-syslog-v2-1-v2-2-f43a3f6b32e4%40nxp.com
patch subject: [PATCH v2 2/2] firmware: imx: sm-misc: Dump syslog info
config: i386-buildonly-randconfig-001-20251012 (https://download.01.org/0day-ci/archive/20251012/202510120607.1JmlmOTI-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251012/202510120607.1JmlmOTI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510120607.1JmlmOTI-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/firmware/imx/sm-misc.c:55:17: warning: unused variable 'dev' [-Wunused-variable]
      55 |         struct device *dev = file->private;
         |                        ^~~
   1 warning generated.


vim +/dev +55 drivers/firmware/imx/sm-misc.c

    50	
    51	static int syslog_show(struct seq_file *file, void *priv)
    52	{
    53		/* 4KB is large enough for syslog */
    54		void *syslog __free(kfree) = kmalloc(SZ_4K, GFP_KERNEL);
  > 55		struct device *dev = file->private;
    56		/* syslog API use num words, not num bytes */
    57		u16 size = SZ_4K / 4;
    58		int ret;
    59	
    60		if (!ph)
    61			return -ENODEV;
    62	
    63		ret = imx_misc_ctrl_ops->misc_syslog(ph, &size, syslog);
    64		if (ret)
    65			return ret;
    66	
    67		seq_hex_dump(file, " ", DUMP_PREFIX_NONE, 16, sizeof(u32), syslog, size * 4, false);
    68		seq_putc(file, '\n');
    69	
    70		return 0;
    71	}
    72	DEFINE_SHOW_ATTRIBUTE(syslog);
    73	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki