linux-kernel - Re: [PATCH 11/26] drm/xe: Allow the caller to pass guc_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202510120724.osgbcJi5-lkp@intel.com>
Date: Sun, 12 Oct 2025 07:35:41 +0800
From: kernel test robot <lkp@...el.com>
To: Michał Winiarski <michal.winiarski@...el.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	Lucas De Marchi <lucas.demarchi@...el.com>,
	Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Jason Gunthorpe <jgg@...pe.ca>, Yishai Hadas <yishaih@...dia.com>,
	Kevin Tian <kevin.tian@...el.com>,
	Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
	intel-xe@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	dri-devel@...ts.freedesktop.org,
	Matthew Brost <matthew.brost@...el.com>,
	Michal Wajdeczko <michal.wajdeczko@...el.com>,
	Jani Nikula <jani.nikula@...ux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
	Tvrtko Ursulin <tursulin@...ulin.net>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Lukasz Laguna <lukasz.laguna@...el.com>,
	Michał Winiarski <michal.winiarski@...el.com>
Subject: Re: [PATCH 11/26] drm/xe: Allow the caller to pass guc_buf_cache size

Hi Michał,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-xe/drm-xe-next]
[also build test ERROR on next-20251010]
[cannot apply to awilliam-vfio/next drm-i915/for-linux-next drm-i915/for-linux-next-fixes linus/master awilliam-vfio/for-linus v6.17]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Micha-Winiarski/drm-xe-pf-Remove-GuC-version-check-for-migration-support/20251012-034301
base:   https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link:    https://lore.kernel.org/r/20251011193847.1836454-12-michal.winiarski%40intel.com
patch subject: [PATCH 11/26] drm/xe: Allow the caller to pass guc_buf_cache size
config: riscv-randconfig-002-20251012 (https://download.01.org/0day-ci/archive/20251012/202510120724.osgbcJi5-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 39f292ffa13d7ca0d1edff27ac8fd55024bb4d19)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251012/202510120724.osgbcJi5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510120724.osgbcJi5-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/xe/xe_guc_buf.c:180:
>> drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c:75:61: error: too many arguments provided to function-like macro invocation
      75 |         KUNIT_ASSERT_EQ(test, 0, xe_guc_buf_cache_init(&guc->buf), SZ_8K);
         |                                                                    ^
   include/kunit/test.h:1358:9: note: macro 'KUNIT_ASSERT_EQ' defined here
    1358 | #define KUNIT_ASSERT_EQ(test, left, right) \
         |         ^
   In file included from drivers/gpu/drm/xe/xe_guc_buf.c:180:
>> drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c:75:2: error: use of undeclared identifier 'KUNIT_ASSERT_EQ'; did you mean 'KUNIT_ASSERTION'?
      75 |         KUNIT_ASSERT_EQ(test, 0, xe_guc_buf_cache_init(&guc->buf), SZ_8K);
         |         ^~~~~~~~~~~~~~~
         |         KUNIT_ASSERTION
   include/kunit/assert.h:27:2: note: 'KUNIT_ASSERTION' declared here
      27 |         KUNIT_ASSERTION,
         |         ^
   In file included from drivers/gpu/drm/xe/xe_guc_buf.c:180:
>> drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c:75:2: warning: expression result unused [-Wunused-value]
      75 |         KUNIT_ASSERT_EQ(test, 0, xe_guc_buf_cache_init(&guc->buf), SZ_8K);
         |         ^~~~~~~~~~~~~~~
   1 warning and 2 errors generated.


vim +75 drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c

    51	
    52	static int guc_buf_test_init(struct kunit *test)
    53	{
    54		struct xe_pci_fake_data fake = {
    55			.sriov_mode = XE_SRIOV_MODE_PF,
    56			.platform = XE_TIGERLAKE, /* some random platform */
    57			.subplatform = XE_SUBPLATFORM_NONE,
    58		};
    59		struct xe_ggtt *ggtt;
    60		struct xe_guc *guc;
    61	
    62		test->priv = &fake;
    63		xe_kunit_helper_xe_device_test_init(test);
    64	
    65		ggtt = xe_device_get_root_tile(test->priv)->mem.ggtt;
    66		guc = &xe_device_get_gt(test->priv, 0)->uc.guc;
    67	
    68		KUNIT_ASSERT_EQ(test, 0,
    69				xe_ggtt_init_kunit(ggtt, DUT_GGTT_START,
    70						   DUT_GGTT_START + DUT_GGTT_SIZE));
    71	
    72		kunit_activate_static_stub(test, xe_managed_bo_create_pin_map,
    73					   replacement_xe_managed_bo_create_pin_map);
    74	
  > 75		KUNIT_ASSERT_EQ(test, 0, xe_guc_buf_cache_init(&guc->buf), SZ_8K);
    76	
    77		test->priv = &guc->buf;
    78		return 0;
    79	}
    80	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki