linux-kernel - Re: [PATCH v1 1/4] usb: dwc3: Add Google SoC DWC3 glue driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202510111335.oyOAs9MB-lkp@intel.com>
Date: Sat, 11 Oct 2025 11:39:41 +0800
From: kernel test robot <lkp@...el.com>
To: Roy Luo <royluo@...gle.com>, Vinod Koul <vkoul@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Peter Griffin <peter.griffin@...aro.org>,
	André Draszik <andre.draszik@...aro.org>,
	Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: oe-kbuild-all@...ts.linux.dev, Joy Chakraborty <joychakr@...gle.com>,
	Naveen Kumar <mnkumar@...gle.com>, Roy Luo <royluo@...gle.com>,
	linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v1 1/4] usb: dwc3: Add Google SoC DWC3 glue driver

Hi Roy,

kernel test robot noticed the following build warnings:

[auto build test WARNING on e5f0a698b34ed76002dc5cff3804a61c80233a7a]

url:    https://github.com/intel-lab-lkp/linux/commits/Roy-Luo/usb-dwc3-Add-Google-SoC-DWC3-glue-driver/20251010-092651
base:   e5f0a698b34ed76002dc5cff3804a61c80233a7a
patch link:    https://lore.kernel.org/r/20251006232125.1833979-2-royluo%40google.com
patch subject: [PATCH v1 1/4] usb: dwc3: Add Google SoC DWC3 glue driver
config: s390-randconfig-002-20251011 (https://download.01.org/0day-ci/archive/20251011/202510111335.oyOAs9MB-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251011/202510111335.oyOAs9MB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510111335.oyOAs9MB-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/usb/dwc3/dwc3-google.c:467:12: warning: 'dwc3_google_resume' defined but not used [-Wunused-function]
     467 | static int dwc3_google_resume(struct dwc3_google *google, pm_message_t msg)
         |            ^~~~~~~~~~~~~~~~~~
>> drivers/usb/dwc3/dwc3-google.c:441:12: warning: 'dwc3_google_suspend' defined but not used [-Wunused-function]
     441 | static int dwc3_google_suspend(struct dwc3_google *google, pm_message_t msg)
         |            ^~~~~~~~~~~~~~~~~~~


vim +/dwc3_google_resume +467 drivers/usb/dwc3/dwc3-google.c

   440	
 > 441	static int dwc3_google_suspend(struct dwc3_google *google, pm_message_t msg)
   442	{
   443		if (pm_runtime_suspended(google->dev))
   444			return 0;
   445	
   446		if (google->dwc.current_dr_role == DWC3_GCTL_PRTCAP_HOST) {
   447			/*
   448			 * Follow dwc3_suspend_common() guidelines for deciding between
   449			 * a full teardown and hibernation.
   450			 */
   451			if (PMSG_IS_AUTO(msg) || device_may_wakeup(google->dev)) {
   452				dev_dbg(google->dev, "enter hibernation");
   453				pm_runtime_get_sync(google->usb_top_pd);
   454				device_wakeup_enable(google->usb_top_pd);
   455				dwc3_google_enable_pme_irq(google);
   456				google->is_hibernation = true;
   457				return 0;
   458			}
   459		}
   460	
   461		reset_control_bulk_assert(google->num_rsts, google->rsts);
   462		clk_bulk_disable_unprepare(google->num_clks, google->clks);
   463	
   464		return 0;
   465	}
   466	
 > 467	static int dwc3_google_resume(struct dwc3_google *google, pm_message_t msg)
   468	{
   469		int ret;
   470	
   471		if (google->is_hibernation) {
   472			dev_dbg(google->dev, "exit hibernation");
   473			dwc3_google_disable_pme_irq(google);
   474			device_wakeup_disable(google->usb_top_pd);
   475			pm_runtime_put_sync(google->usb_top_pd);
   476			google->is_hibernation = false;
   477			return 0;
   478		}
   479	
   480		ret = clk_bulk_prepare_enable(google->num_clks, google->clks);
   481		if (ret)
   482			return ret;
   483	
   484		ret = reset_control_bulk_deassert(google->num_rsts, google->rsts);
   485		if (ret) {
   486			clk_bulk_disable_unprepare(google->num_clks, google->clks);
   487			return ret;
   488		}
   489	
   490		return 0;
   491	}
   492	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki