linux-kernel - Re: [PATCH v3 2/5] iio: accel: bma400: Use macros for generic event configuration values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251012150426.52605ea8@jic23-huawei>
Date: Sun, 12 Oct 2025 15:04:26 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Akshay Jindal <akshayaj.lkd@...il.com>
Cc: dan@...obertson.com, dlechner@...libre.com, nuno.sa@...log.com,
 andy@...nel.org, shuah@...nel.org, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/5] iio: accel: bma400: Use macros for generic event
 configuration values


> > > +enum bma400_genintr_acceleval_axescomb {
> > > +     BMA400_EVAL_X_OR_Y_OR_Z,
> > > +     BMA400_EVAL_X_AND_Y_AND_Z,  
> >
> > An enum for potential field values only makes sense if you are going to
> > use it as a type somewhere.  If not it is simpler to just
> > use a define next to the mask for the field.  Also these should be named
> > with prefixes that align with that mask.
> > If you do use it as a type in future patches that's fine but the naming
> > point still remains and you should specify values = 0, = 1 etc
> > as they matter whereas implication of using an enum is that the actual
> > values assigned doesn't matter.
> >
> > Same applies to the other enums introduced in here.  
> Assigned explicit values to enums in v4 patch series.
> 
Hi Akshay,

Trivial process thing.  This email doesn't need to exist. Just
have the change called out in the change log for v4.  That way it
saves a bit of time for everyone.

Thanks,

Jonathan

> Thanks,
> Akshay.