linux-kernel - Re: [PATCH 06/22] smb: move SMB1_PROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7A6DE7EAED2A073C+7e132ed4-089d-4fff-873c-de03ea76c4c4@chenxiaosong.com>
Date: Sun, 12 Oct 2025 23:33:58 +0800
From: chenxiaosong <chenxiaosong@...nxiaosong.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 stfrench@...rosoft.com, metze@...ba.org, pali@...nel.org,
 linkinjeon@...nel.org, smfrench@...il.com, sfrench@...ba.org,
 senozhatsky@...omium.org, tom@...pey.com, pc@...guebit.org,
 ronniesahlberg@...il.com, sprasad@...rosoft.com, bharathsm@...rosoft.com,
 zhangguodong@...inos.cn
Cc: linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
 ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: Re: [PATCH 06/22] smb: move SMB1_PROTO_NUMBER to common/cifsglob.h

Yes, "cpu_to_le32()" should not be present, I'll send v2 patchset.

Thanks for reply.

On 2025/10/12 23:21, Christophe JAILLET wrote:
> Le 12/10/2025 à 17:08, chenxiaosong@...nxiaosong.com a écrit :

>>       /* does it have the right SMB "signature" ? */
>> -    if (*(__le32 *) smb->Protocol != cpu_to_le32(0x424d53ff)) {
>> +    if (*(__le32 *) smb->Protocol != cpu_to_le32(SMB1_PROTO_NUMBER)) {
> 
> Should this be SMB1_PROTO_NUMBER?
> (without cpu_to_le32())
> 
> CJ
>