linux-kernel - Re: [PATCH v4 4/6] iio: accel: bma400: Replace bit shifts with FIELD_PREP and FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251012165415.18d6154b@jic23-huawei>
Date: Sun, 12 Oct 2025 16:54:15 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Akshay Jindal <akshayaj.lkd@...il.com>
Cc: dan@...obertson.com, dlechner@...libre.com, nuno.sa@...log.com,
 andy@...nel.org, shuah@...nel.org, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/6] iio: accel: bma400: Replace bit shifts with
 FIELD_PREP and FIELD_GET

On Tue,  7 Oct 2025 11:25:04 +0530
Akshay Jindal <akshayaj.lkd@...il.com> wrote:

> set_* functions involve left shift of param values into respective
> register fields before writing to register. Similarly get_* functions
> involve right shift to extract values from the respective bit fields.
> Replace these explicit shifting statements with standard kernel style
> macros FIELD_GET and FIELD_PREP.

Trivial but FIELD_GET() and FIELD_PREP() in patch descriptions (And title).
That helps show they take parameters and are function like.

> 
> Signed-off-by: Akshay Jindal <akshayaj.lkd@...il.com>
Code looks good to me

Jonathan