[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251012181043.510976c8@jic23-huawei>
Date: Sun, 12 Oct 2025 18:10:43 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Lakshay Piplani <lakshay.piplani@....com>
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
marcelo.schmitt1@...il.com, gregkh@...uxfoundation.org,
viro@...iv.linux.org.uk, peterz@...radead.org, jstephan@...libre.com,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
devicetree@...r.kernel.org, jdelvare@...e.com, linux@...ck-us.net,
vikash.bansal@....com, priyanka.jain@....com, shashank.rebbapragada@....com
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: temperature: Add NXP P3T175x
support
On Wed, 8 Oct 2025 15:37:12 +0530
Lakshay Piplani <lakshay.piplani@....com> wrote:
> Add bindings for the NXP P3T175x (P3T1750/P3T1755) temperature
> sensor, supporting both I2C & I3C interfaces.
>
> The P3T1750 and P3T1755 are functionally equivalent temperature
> sensors with identical interfaces and features. The P3T1755 offers
> improved accuracy(±0.5°C) in the –20°C to +85°C range, while both
> maintain ±1°C accuracy across –40°C to +125°C.
>
> Signed-off-by: Lakshay Piplani <lakshay.piplani@....com>
> ---
> V3 -> V4: Changes since V3:
> - Updated commit message to clarify the difference between P3T1750 and P3T1755.
> V2 -> V3: Changes since V2:
> - Removed nxp,interrupt-mode and nxp,fault-queue properties from DT binding
> - Updated compatible strings:
> - nxp,p3t1750-iio → nxp,p3t1750dp
> - nxp,p3t1755-iio → nxp,p3t1755dp
> V1 -> V2: Changes since V1:
> - Dropped nxp,alert-active-high
> - Fixed YAML formatting, line wrapping, and examples
>
> .../bindings/iio/temperature/nxp,p3t1755.yaml | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/temperature/nxp,p3t1755.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/temperature/nxp,p3t1755.yaml b/Documentation/devicetree/bindings/iio/temperature/nxp,p3t1755.yaml
> new file mode 100644
> index 000000000000..16a01fa81251
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/temperature/nxp,p3t1755.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/temperature/nxp,p3t1755.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP P3T175xDP Temperature Sensor
> +
> +maintainers:
> + - Lakshay Piplani <lakshay.piplani@....com>
> +
> +description: |
> + Datasheet: https://www.nxp.com/docs/en/data-sheet/P3T1755.pdf
> +
> + P3T175xDP (P3T1750/P3T1755) is a digital temperature sensor with a range of
> + -40°C to +125°C and a 12-bit resolution. It supports communication over both
> + I2C and I3C interfaces.
> +
> + The I2C interface supports up to 32 static addresses and provides an ALERT
> + output to signal when temperature thresholds are crossed.
> +
> + The I3C interface supports In-Band interrupts (IBI) in interrupt mode,
> + allowing the device to notify the controller of threshold events without
> + dedicated alert pin.
> +
> +properties:
> + compatible:
> + enum:
> + - nxp,p3t1750dp
> + - nxp,p3t1755dp
> +
> + interrupts:
> + maxItems: 1
> +
> + reg:
> + maxItems: 1
> + description: |
> + In I2C mode, the device supports up to 32 static addresses.
> + In I3C mode, the 'reg' property encodes a triplet of
> + <static-address BCR PID> used for device matching.
> + Static address is optional if matching is done via PID.
> +
Aim for completeness of description. This sensor needs power so
there should be a regulator. As power must be connected convention
is to make that required as well. That doesn't necessarily mean
specific dts can't rely on fallback 'fake' regulators that get created
by Linux when one is requested that we haven't provided in DT though.
For driver side just use devm_regulator_get_enabled() and forget about it
after that.
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + temp-sensor@48 {
> + compatible = "nxp,p3t1755dp";
> + reg = <0x48>;
> + interrupt-parent = <&gpio2>;
> + interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
> + };
> + };
Powered by blists - more mailing lists