linux-kernel - Re: [PATCH v10 2/4] PCI/VGA: Replace vga_is_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1be1a119-1fbd-435f-bb27-70f48d677ebf@kernel.org>
Date: Sun, 12 Oct 2025 13:37:33 -0500
From: Mario Limonciello <superm1@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: David Airlie <airlied@...il.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
 open list <linux-kernel@...r.kernel.org>,
 "open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>,
 Daniel Dadap <ddadap@...dia.com>
Subject: Re: [PATCH v10 2/4] PCI/VGA: Replace vga_is_firmware_default() with a
 screen info check



On 10/12/25 1:23 PM, Eric Biggers wrote:
> Hi,
> 
> On Mon, Aug 11, 2025 at 11:26:04AM -0500, Mario Limonciello (AMD) wrote:
>> vga_is_firmware_default() checks firmware resources to find the owner
>> framebuffer resources to find the firmware PCI device.  This is an
>> open coded implementation of screen_info_pci_dev().  Switch to using
>> screen_info_pci_dev() instead.
>>
>> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
>> Suggested-by: Thomas Zimmermann <tzimmermann@...e.de>
>> Signed-off-by: Mario Limonciello (AMD) <superm1@...nel.org>
> 
> I'm getting a black screen on boot on mainline, and it bisected to this
> commit.  Reverting this commit fixed it.
> 
> Please revert.
> 
> - Eric

Can you please share more information about your issue before we jump 
straight into a revert?  What kind of hardware do you have?  Perhaps a 
kernel log from mainline and another from mainline with the revert could 
help identify what's going on?

A revert might be the right solution, but I would rather fix the issue 
if it's plausible to do so.