linux-kernel - Re: [PATCH] iio: adc: ad7280a: fix ad7280_store_balance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251012195956.0b87bb7f@jic23-huawei>
Date: Sun, 12 Oct 2025 19:59:56 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: David Lechner <dlechner@...libre.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Nuno
 Sá	 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Marcelo Schmitt	 <marcelo.schmitt1@...il.com>, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7280a: fix ad7280_store_balance_timer()

On Fri, 10 Oct 2025 20:02:44 +0100
Nuno Sá <noname.nuno@...il.com> wrote:

> On Fri, 2025-10-10 at 10:44 -0500, David Lechner wrote:
> > Use correct argument to iio_str_to_fixpoint() to parse 3 decimal places.
> > 
> > iio_str_to_fixpoint() has a bit of an unintuitive API where the
> > fract_mult parameter is the multiplier of the first decimal place as if
> > it was already an integer.  So to get 3 decimal places, fract_mult must
> > be 100 rather than 1000.

I'd completely forgotten about that...

> > 
> > Fixes: 96ccdbc07a74 ("staging:iio:adc:ad7280a: Standardize extended ABI naming")
> > Signed-off-by: David Lechner <dlechner@...libre.com>
> > ---  
> 
> Reviewed-by: Nuno Sá <nuno.sa@...log.com>
Applied and +CC stable.

> 
> >  drivers/iio/adc/ad7280a.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/ad7280a.c b/drivers/iio/adc/ad7280a.c
> > index
> > dda2986ccda075fbfa04851a1ceac7a186b47537..50a6ff7c8b1c73905fabdef119d41204c32b590c
> > 100644
> > --- a/drivers/iio/adc/ad7280a.c
> > +++ b/drivers/iio/adc/ad7280a.c
> > @@ -541,7 +541,7 @@ static ssize_t ad7280_store_balance_timer(struct iio_dev
> > *indio_dev,
> >  	int val, val2;
> >  	int ret;
> >  
> > -	ret = iio_str_to_fixpoint(buf, 1000, &val, &val2);
> > +	ret = iio_str_to_fixpoint(buf, 100, &val, &val2);
> >  	if (ret)
> >  		return ret;
> >  
> > 
> > ---
> > base-commit: a9682f53c2d1678b93a123cdaa260e955430bc5c
> > change-id: 20251010-iio-adc-ad7280a-fix-ad7280_store_balance_timer-126bc5b4ee90
> > 
> > Best regards,  
>