linux-kernel - Re: [PATCH] iio: imu: bmi270: fix dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251012200511.0a622220@jic23-huawei>
Date: Sun, 12 Oct 2025 20:05:11 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
Cc: lanzano.alex@...il.com, dlechner@...libre.com, nuno.sa@...log.com,
 andy@...nel.org, ~lkcamp/patches@...ts.sr.ht, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: imu: bmi270: fix dev_err_probe error msg

On Fri, 10 Oct 2025 16:06:46 -0300
Rodrigo Gobbi <rodrigo.gobbi.7@...il.com> wrote:

> The bmi270 can be connected to I2C or a SPI interface. If it is a SPI,
> during probe, if devm_regmap_init() fails, it should print the "spi"
> term rather "i2c".
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
> ---
> Just fixing this little "typo", definitely it was copied from the bmi270_i2c.c [1],
> which has the same dev_err_probe logic.
> Tks and regards.
> 
> [1] https://github.com/torvalds/linux/blob/master/drivers/iio/imu/bmi270/bmi270_i2c.c#L30

Given the confusion this could cause I'm thinking this should go to stable.
It needs a fixes tag.

thanks,

Jonathan

> ---
>  drivers/iio/imu/bmi270/bmi270_spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/bmi270/bmi270_spi.c b/drivers/iio/imu/bmi270/bmi270_spi.c
> index 19dd7734f9d0..5e625586681d 100644
> --- a/drivers/iio/imu/bmi270/bmi270_spi.c
> +++ b/drivers/iio/imu/bmi270/bmi270_spi.c
> @@ -60,7 +60,7 @@ static int bmi270_spi_probe(struct spi_device *spi)
>  				  &bmi270_spi_regmap_config);
>  	if (IS_ERR(regmap))
>  		return dev_err_probe(dev, PTR_ERR(regmap),
> -				     "Failed to init i2c regmap");
> +				     "Failed to init spi regmap");
>  
>  	return bmi270_core_probe(dev, regmap, chip_info);
>  }