linux-kernel - Re: [PATCH 01/32] Input: cyttsp5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aO0cXYeGLwwDABP6@lizhi-Precision-Tower-5810>
Date: Mon, 13 Oct 2025 11:35:57 -0400
From: Frank Li <Frank.li@....com>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Hans Verkuil <hverkuil@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Krzysztof Hałasa <khalasa@...p.pl>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Leon Luo <leonl@...pardimaging.com>,
	Kieran Bingham <kieran.bingham@...asonboard.com>,
	Jacopo Mondi <jacopo+renesas@...ndi.org>,
	Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>,
	Julien Massot <julien.massot@...labora.com>,
	Jacopo Mondi <jacopo@...ndi.org>,
	Daniel Scally <djrscally@...il.com>,
	Dave Stevenson <dave.stevenson@...pberrypi.com>,
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Sylvain Petinot <sylvain.petinot@...s.st.com>,
	Yong Zhi <yong.zhi@...el.com>, Bingbu Cao <bingbu.cao@...el.com>,
	Tianshu Qiu <tian.shu.qiu@...el.com>,
	Tiffany Lin <tiffany.lin@...iatek.com>,
	Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
	Yunfei Dong <yunfei.dong@...iatek.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Rui Miguel Silva <rmfrfs@...il.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Martin Kepplinger <martink@...teo.de>,
	Purism Kernel Team <kernel@...i.sm>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Dafna Hirschfeld <dafna@...tmail.com>,
	Heiko Stuebner <heiko@...ech.de>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Yemike Abhilash Chandra <y-abhilashchandra@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, imx@...ts.linux.dev,
	linux-renesas-soc@...r.kernel.org,
	linux-rockchip@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH 01/32] Input: cyttsp5 - Use %pe format specifier

On Mon, Oct 13, 2025 at 02:14:41PM +0000, Ricardo Ribalda wrote:
> The %pe format specifier is designed to print error pointers. It prints
> a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> omitting PTR_ERR()
>
> This patch fixes this cocci report:
> ./cyttsp5.c:927:3-10: WARNING: Consider using %pe to print PTR_ERR()
>
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> ---
>  drivers/input/touchscreen/cyttsp5.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Suppose it will go though input subsystem intead of media.
Need post seperated at difference thread?

Frank

>
> diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
> index 071b7c9bf566eb0b58e302a941ec085be1eb5683..47f4271395a69b8350f9be7266b57fe11d442ee3 100644
> --- a/drivers/input/touchscreen/cyttsp5.c
> +++ b/drivers/input/touchscreen/cyttsp5.c
> @@ -923,8 +923,8 @@ static int cyttsp5_i2c_probe(struct i2c_client *client)
>
>  	regmap = devm_regmap_init_i2c(client, &config);
>  	if (IS_ERR(regmap)) {
> -		dev_err(&client->dev, "regmap allocation failed: %ld\n",
> -			PTR_ERR(regmap));
> +		dev_err(&client->dev, "regmap allocation failed: %pe\n",
> +			regmap);
>  		return PTR_ERR(regmap);
>  	}
>
>
> --
> 2.51.0.760.g7b8bcc2412-goog
>