linux-kernel - Re: [PATCH 01/11] irqchip/bcm2712-mip: Fix OF node reference imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf25d367-e98a-4475-b09a-55d6d47e428c@broadcom.com>
Date: Mon, 13 Oct 2025 08:56:11 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Johan Hovold <johan@...nel.org>, Thomas Gleixner <tglx@...utronix.de>
Cc: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Claudiu Beznea
 <claudiu.beznea@...on.dev>, Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 Changhuang Liang <changhuang.liang@...rfivetech.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Magnus Damm <magnus.damm@...il.com>, linux-kernel@...r.kernel.org,
 Stanimir Varbanov <svarbanov@...e.de>
Subject: Re: [PATCH 01/11] irqchip/bcm2712-mip: Fix OF node reference
 imbalance

On 10/13/25 02:46, Johan Hovold wrote:
> The init callback must not decrement the reference count of the provided
> irqchip OF node.
> 
> This should not cause any trouble currently, but if the driver ever
> starts probe deferring it could lead to warnings about reference
> underflow and saturation.
> 
> Fixes: 32c6c054661a ("irqchip: Add Broadcom BCM2712 MSI-X interrupt controller")
> Cc: Stanimir Varbanov <svarbanov@...e.de>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian