linux-kernel - Re: [PATCH next] EDAC/versalnet: Fix off by one in handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251013170423.GEaO0xF48HklVENi05@fat_crate.local>
Date: Mon, 13 Oct 2025 19:04:23 +0200
From: Borislav Petkov <bp@...en8.de>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Shubhrajyoti Datta <shubhrajyoti.datta@....com>,
	Tony Luck <tony.luck@...el.com>, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] EDAC/versalnet: Fix off by one in handle_error()

On Sat, Sep 27, 2025 at 03:26:34PM +0300, Dan Carpenter wrote:
> The priv->mci[] array has NUM_CONTROLLERS so this > comparison needs to
> be >= to prevent an out of bounds access.
> 
> Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/edac/versalnet_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c
> index 7c5db8bf0595..1ded4c3f0213 100644
> --- a/drivers/edac/versalnet_edac.c
> +++ b/drivers/edac/versalnet_edac.c
> @@ -433,7 +433,7 @@ static void handle_error(struct mc_priv  *priv, struct ecc_status *stat,
>  	phys_addr_t pfn;
>  	int err;
>  
> -	if (WARN_ON_ONCE(ctl_num > NUM_CONTROLLERS))
> +	if (WARN_ON_ONCE(ctl_num >= NUM_CONTROLLERS))
>  		return;
>  
>  	mci = priv->mci[ctl_num];
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette