linux-kernel - Re: [PATCH net v7 4/4] selftest: netcons: add test for netconsole over bonded interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <poknlppzfnzkaxkiz5schua5tuwbssaimihaht3ebvxzwxgztg@jfkdpdri6n4r>
Date: Mon, 13 Oct 2025 10:28:10 -0700
From: Breno Leitao <leitao@...ian.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Shuah Khan <shuah@...nel.org>, Simon Horman <horms@...nel.org>, 
	david decotigny <decot@...glers.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, asantostc@...il.com, efault@....de, calvin@...nvd.org, 
	kernel-team@...a.com, jv@...sburgh.net
Subject: Re: [PATCH net v7 4/4] selftest: netcons: add test for netconsole
 over bonded interfaces

On Wed, Oct 08, 2025 at 06:02:56AM -0700, Breno Leitao wrote:

> > Note that with the create_netdevsim() helper from
> > tools/testing/selftests/net/lib.sh you could create the netdevsim device
> > directly in the target namespace and avoid some duplicate code.
> 
> Awesome. I am more than happy to create_netdevsim() in this selftest,
> and move the others to use it as well.
> 
> > It would be probably safer to create both rx and tx devices in child
> > namespaces.
> 
> Sure, that is doable, but, I need to change a few common helpers, to
> start netconsole from inside the "tx namespace" instead of the default
> namespace.
> 
> Given all the other netconsole selftest uses TX from the default net
> namespace, I would like to move them at all the same time.
> 
> Do you think it is Ok to have this test using TX interfaces from the
> main net namespace (as is now), and then I submit a follow patch to
> migrate all the netcons tests (including this one) to use a TX
> namespace? Then I can change the helpers at the same time, simplifying
> the code review.

In fact, I was able to isolate the functions for the isolation in the
self test, and now I have a test that relies on create_netdevsim() and
have two namespaces, one for TX and one for RX.

The problem is that it hits a bug on netdevsim that doesn't allow it to
run properly. Basically create_netdevsim() put the interface up, and
I need to get the interface down in order to enslaved it, losing the
carrier.

I've propsoed a fix in here:

https://lore.kernel.org/all/20251013-netdevsim_fix-v1-1-357b265dd9d0@debian.org/

So, I will send a new version for this patchset soon, but, it will
probably not pass the CI, given it will not have the fix aboveyet. But
I will send it anyway, so, people can further review the patchset.

Thanks
--breno