linux-kernel - RE: [PATCH v3 1/3] dt-binding: display: Add ITE IT61620 MIPI DSI to HDMI bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <663a3ee90e81451894d280a06ea4ecb5@ite.com.tw>
Date: Mon, 13 Oct 2025 03:49:44 +0000
From: <Pet.Weng@....com.tw>
To: <krzk@...nel.org>, <andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>,
        <rfoss@...nel.org>, <Laurent.pinchart@...asonboard.com>,
        <jonas@...boo.se>, <jernej.skrabec@...il.com>,
        <maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
        <tzimmermann@...e.de>, <airlied@...il.com>, <simona@...ll.ch>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>
CC: <dri-devel@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <Hermes.Wu@....com.tw>,
        <Kenneth.Hung@....com.tw>, <treapking@...gle.com>
Subject: RE: [PATCH v3 1/3] dt-binding: display: Add ITE IT61620 MIPI DSI to
 HDMI bridge

Hi Krzysztof,
> On 09/10/2025 23:13, Krzysztof Kozlowski wrote:
> > On 09/10/2025 17:02, Pet Weng wrote:
> >> +  The HDMI transmitter side supports up to 4Kx2K@...z resolutions, and is
> >> +  compliant with HDMI 1.4b and HDCP 1.4.
> >> +
> >> +  For audio, the IT61620 supports up to 8-channel LPCM via I2S (multi-line or
> >> +  TDM mode), with optional S/PDIF or DSD (for SACD). It supports audio
> >> +  sampling rates up to 192kHz.
> >> +
> >> +allOf:
> >> +  - $ref: /schemas/sound/dai-common.yaml#
> >> +
> >> +properties:
> >> +  compatible:
> >> +    const: ite,it61620
> >> +
> >> +  reg:
> >> +    maxItems: 1
> >> +
> >> +  interrupts:
> >> +    maxItems: 1
> >> +    description: interrupt specifier of INT pin
> >> +
> >> +  reset-gpios:
> >> +    maxItems: 1
> >> +    description: GPIO specifier of RESET pin
> >
> >
> > If you are going to send new version: drop description, pretty
> > redundant. Cannot be anything else.
> >
> >> +
> >> +  ivdd-supply:
> >> +    description: core voltage
> >> +
> >> +  ovdd-supply:
> >> +    description: I/O voltage
> >> +
> >> +  ovdd1833-supply:
> >> +    description: flexible I/O votage
> >> +
> >> +  pinctrl-names:
> >> +    items:
> >> +      - const: default
> >> +
> >> +  pinctrl-0:
> >> +    maxItems: 1
> >
> >
> > Both pinctrl properties are usually redundant here. Does your driver
> > actually require them?
> 
> And now I checked and I do not see direct usage in the driver or did I
> miss something?

Acknowledged. Will drop `pinctrl-names` and `pinctrl-0` in the next version.
Thanks for the review.

> 
> Best regards,
> Krzysztof

Best regards,
Pet