linux-kernel - Re: [PATCH v2 2/3] dt-bindings: interrupt-controller: add UltraRISC DP1000 PLIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251013-commute-bountiful-208ade035c86@spud>
Date: Mon, 13 Oct 2025 19:25:54 +0100
From: Conor Dooley <conor@...nel.org>
To: Lucas Zampieri <lzampier@...hat.com>
Cc: devicetree@...r.kernel.org, Charles Mirabile <cmirabil@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Samuel Holland <samuel.holland@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	Vivian Wang <dramforever@...e.com>, linux-riscv@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: interrupt-controller: add UltraRISC
 DP1000 PLIC

On Mon, Oct 13, 2025 at 12:15:37PM +0100, Lucas Zampieri wrote:
> From: Charles Mirabile <cmirabil@...hat.com>
> 
> Add a new compatible string for UltraRISC DP1000 PLIC.
> 
> Signed-off-by: Charles Mirabile <cmirabil@...hat.com>
> Signed-off-by: Lucas Zampieri <lzampier@...hat.com>
> ---
>  .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
> index 5b827bc24301..a419de50f5a8 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
> @@ -74,6 +74,8 @@ properties:
>                - sophgo,sg2044-plic
>                - thead,th1520-plic
>            - const: thead,c900-plic
> +      - items:
> +          - const: ultrarisc,dp1000-plic
> +          - const: ultrarisc,cp100-plic

Based on your cover letter, this is problem not incorrect, but this fails
the eye test and looks wrong. Please mention in your commit message that
dp1000 is an soc and cp100 is a purchasable IP core.

pw-bot: changes-requested

>        - items:
>            - const: sifive,plic-1.0.0
>            - const: riscv,plic0
> --
> 2.51.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)