linux-kernel - Re: [PATCH 2/2] dmaengine: dw-axi-dmac: add reset control support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOPX746fn30c9zVk1Wrsgy86zccEHRGuhraUoS=qsFz11QSeWA@mail.gmail.com>
Date: Mon, 13 Oct 2025 23:08:00 +0300
From: Artem Shimko <a.shimko.dev@...il.com>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>, Vinod Koul <vkoul@...nel.org>, 
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dmaengine: dw-axi-dmac: add reset control support

Hi Philipp,

On Mon, Oct 13, 2025 at 6:41 PM Philipp Zabel <p.zabel@...gutronix.de> wrote:
>
> On Mo, 2025-10-13 at 17:56 +0300, Artem Shimko wrote:
>
> [...]
> > dw_remove() has axi_dma_suspend() function, which is where the reset assertion
> > occurs via reset_control_assert().
>
> It looks to me like dw_remove() is now missing a deassert before
> accessing registers, in case the device is removed while runtime
> suspended.
>
> regards
> Philipp

oh, I see, it looks like we have to insert reset_control_deassert(chip->resets);
just after clk_prepare_enable(chip->cfgr_clk);...

You're absolutely right!

Just realized I may have been too quick with v2. Will wait for more
feedback and send v3.

Best regards,
Artem Shimko