lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aO1gOckA14Ed/26F@visitorckw-System-Product-Name>
Date: Tue, 14 Oct 2025 04:25:29 +0800
From: Kuan-Wei Chiu <visitorckw@...il.com>
To: Ankan Biswas <spyjetfayed@...il.com>,
	Lasse Collin <lasse.collin@...aani.org>
Cc: lasse.collin@...aani.org, skhan@...uxfoundation.org, khalid@...nel.org,
	david.hunter.linux@...il.com, linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH v2] lib/xz: remove dead IA-64 (Itanium) support code

On Mon, Oct 13, 2025 at 11:01:58PM +0530, Ankan Biswas wrote:
> Support for the IA-64 (Itanium) architecture was removed in
> commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture").
> 
> This patch drops the IA-64 specific decompression code from
> lib/xz, which was conditionally compiled with the now-obsolete
> CONFIG_XZ_DEC_IA64 option.
> 
> Note that the upstream version of xz_dec_bcj.c still retains support
> for the IA-64 BCJ filter.

Not sure if it's necessary to mention this, but I guess it's fine.

> 
> Signed-off-by: Ankan Biswas <spyjetfayed@...il.com>
> Acked-by: Lasse Collin <lasse.collin@...aani.org>
> ---

I'm not quite sure what you changed in v2 compared to v1.
Usually, you should describe the changes below the --- line [1].

[1]: https://www.kernel.org/doc/html/v6.17/process/submitting-patches.html#commentary

However, the change itself LGTM, so FWIW:

Reviewed-by: Kuan-Wei Chiu <visitorckw@...il.com>

Lasse,
Since this change is located under lib/, I assume it will be routed
through Andrew's tree?
If that's the case, then perhaps we should also Cc Andrew.

Regards,
Kuan-Wei

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ