linux-kernel - Re: [PATCH] HID: Kconfig: Fix build error from CONFIG_HID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMCVhVNLr+2ivRo9T4rVt4mkncwbOfXEL9bE=pDGRp=Qjy1c9A@mail.gmail.com>
Date: Mon, 13 Oct 2025 16:23:36 -0500
From: Jonathan Denose <jdenose@...gle.com>
To: Kuan-Wei Chiu <visitorckw@...il.com>
Cc: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>, 
	Thorsten Leemhuis <linux@...mhuis.info>, Randy Dunlap <rdunlap@...radead.org>, 
	Lucas GISSOT <lucas.gissot.pro@...il.com>, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: Kconfig: Fix build error from CONFIG_HID_HAPTIC

On Mon, Oct 13, 2025 at 4:11 PM Kuan-Wei Chiu <visitorckw@...il.com> wrote:
>
> On Mon, Oct 13, 2025 at 08:54:57PM +0000, Jonathan Denose wrote:
> > Temporarily change CONFIG_HID_HAPTIC to be bool instead of tristate, until
> > we implement a permanent solution.
> >
> > ---
>
> The "---" line here will cause many tools used for applying patches,
> like git am, to discard the content below it [1].
>
> Please don't add this line unless you don't want the following content
> to appear in the commit message.
>
> [1]: https://www.kernel.org/doc/html/v6.17/process/submitting-patches.html#commentary
>
> Regards,
> Kuan-Wei

Yes, that was intentional, the information below the '---' was
included as additional information and not for the commit message. The
error messages were too long, as was the link to the longer
discussion, and this caused errors in checkpatch.pl.

> > Recently the CONFIG_HID_HAPTIC Kconfig option was reported as causing
> > the following build errors:
> >
> >   MODPOST Module.symvers
> > ERROR: modpost: "hid_haptic_init" [drivers/hid/hid-multitouch.ko] undefined!
> > ERROR: modpost: "hid_haptic_pressure_increase" [drivers/hid/hid-multitouch.ko] undefined!
> > ERROR: modpost: "hid_haptic_check_pressure_unit" [drivers/hid/hid-multitouch.ko] undefined!
> > ERROR: modpost: "hid_haptic_input_configured" [drivers/hid/hid-multitouch.ko] undefined!
> > ERROR: modpost: "hid_haptic_input_mapping" [drivers/hid/hid-multitouch.ko] undefined!
> > ERROR: modpost: "hid_haptic_feature_mapping" [drivers/hid/hid-multitouch.ko] undefined!
> > ERROR: modpost: "hid_haptic_pressure_reset" [drivers/hid/hid-multitouch.ko] undefined!
> > make[3]: *** [/home/thl/var/linux.dev/scripts/Makefile.modpost:147: Module.symvers] Error 1
> >
> > when the kernel is compiled with the following configuration:
> >
> > CONFIG_HID=y
> > CONFIG_HID_MULTITOUCH=m
> > CONFIG_HID_HAPTIC=m
> >
> > To resolve this, temporarily change the CONFIG_HID_HAPTIC option to be
> > bool, until we arrive at a permanent solution to enable CONFIG_HID_HAPTIC
> > to be tristate.
> >
> > For a more detailed discussion, see [1].
> >
> > [1]: https://lore.kernel.org/linux-input/auypydfkhx2eg7vp764way4batdilzc35inqda3exwzs3tk3ff@oagat6g46zto/
> >
> > Signed-off-by: Jonathan Denose <jdenose@...gle.com>
> > ---
> >  drivers/hid/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> > index 5341aa79f387bd0e5a76266b5928d2c978dd81cf..04420a713be085c8871b4d35255fde4cafd8de0f 100644
> > --- a/drivers/hid/Kconfig
> > +++ b/drivers/hid/Kconfig
> > @@ -93,7 +93,7 @@ config HID_GENERIC
> >       If unsure, say Y.
> >
> >  config HID_HAPTIC
> > -     tristate "Haptic touchpad support"
> > +     bool "Haptic touchpad support"
> >       default n
> >       help
> >       Support for touchpads with force sensors and haptic actuators instead of a
> >
> > ---
> > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> > change-id: 20251013-hid-haptic-kconfig-fix-634df2bdac1d
> >
> > Best regards,
> > --
> > Jonathan Denose <jdenose@...gle.com>
> >
-- 
Jonathan