linux-kernel - Re: [PATCH] mtd: spi-nor: Enable locking for n25q00a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33cbbac1-c247-4644-b555-998eea6e8305@linaro.org>
Date: Mon, 13 Oct 2025 08:30:24 +0100
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Sean Anderson <sean.anderson@...ux.dev>,
 Pratyush Yadav <pratyush@...nel.org>
Cc: Michael Walle <mwalle@...nel.org>, linux-mtd@...ts.infradead.org,
 Richard Weinberger <richard@....at>, linux-kernel@...r.kernel.org,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH] mtd: spi-nor: Enable locking for n25q00a

Sean,

On 10/10/25 4:45 PM, Sean Anderson wrote:

>> ... or, you know, read the data sheet, write the driver, and _test_ if
>> it actually works?
> 
> Which I did.

cut

> - Locking is not in your suggested test procedure for new flashes
>   (although it probably should be if you're so gung ho about mistrusting
>   datasheets). 

cut

> There is no evidence that the status register has three bits (except
> when the flash has 64 eraseblocks or fewer), and there overwhelming
> evidence to the contrary.

Nobody challenged that your flash has 4 BP bits. I/we just want the proof
that you did the tests, i.e. show the output of the mtd-utils locking tests.

I also need you to dump the sysfs/debugs entries.

It's true that the locking tests are not yet described in
https://docs.kernel.org/driver-api/mtd/spi-nor.html, that's why I encouraged
you to show us how you did the testing and maybe to contribute and extend
the documentation.

Cheers,
ta