linux-kernel - Re: [PATCH v5 2/4] PCI: endpoint: Add helper function pci_epf_get_bar_required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aOzAqwFysJ0d5zMr@ryzen>
Date: Mon, 13 Oct 2025 11:04:43 +0200
From: Niklas Cassel <cassel@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Manivannan Sadhasivam <mani@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Jon Mason <jdmason@...zu.us>,
	Dave Jiang <dave.jiang@...el.com>, Allen Hubbe <allenbh@...il.com>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	ntb@...ts.linux.dev, imx@...ts.linux.dev
Subject: Re: [PATCH v5 2/4] PCI: endpoint: Add helper function
 pci_epf_get_bar_required_size()

On Thu, Oct 09, 2025 at 04:54:36PM -0400, Frank Li wrote:
> Introduce pci_epf_get_bar_required_size() to retrieve the required BAR
> size and memory size. Prepare for adding support to set an MMIO address to
> a specific BAR.
> 
> Use two variables 'size' and 'aligned_mem_size' to avoid confuse.

Nit: I still think this is wrong. Probably:
Use two parameters 'bar_size' and 'aligned_mem_size' to avoid confusion.

> 
> No functional changes.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>

Reviewed-by: Niklas Cassel <cassel@...nel.org>