linux-kernel - Re: [PATCH v5 3/3] arm64: dts: rockchip: add LinkEase EasePi R1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251013070036.66901-1-amadeus@jmu.edu.cn>
Date: Mon, 13 Oct 2025 15:00:36 +0800
From: Chukun Pan <amadeus@....edu.cn>
To: jjm2473@...il.com
Cc: conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	heiko@...ech.de,
	krzk+dt@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-rockchip@...ts.infradead.org,
	Chukun Pan <amadeus@....edu.cn>
Subject: Re: [PATCH v5 3/3] arm64: dts: rockchip: add LinkEase EasePi R1

Hi,

> +	regulator-vdd0v95-25glan {
> +		compatible = "regulator-fixed";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pwr_25g_pin>;
> +		enable-active-high;
> +		gpio = <&gpio3 RK_PB1 GPIO_ACTIVE_HIGH>;
> +		regulator-name = "vdd0v95_25glan";
> +		regulator-min-microvolt = <950000>;
> +		regulator-max-microvolt = <950000>;
> +		regulator-boot-on;
> +		regulator-always-on;

The property order should be consistent with other nodes.

> +		vin-supply = <&vcc3v3_sys>;
> +	};
> +
> +	vcc3v3_nvme: regulator-vcc3v3-nvme {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc3v3_nvme";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		enable-active-high;
> +		gpio = <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>;
> +		vin-supply = <&dc_12v>;

Same here, keep alphabetical order.

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&vcc3v3_nvme_en>;
> +	};

> +		status_led: led-status {
> +			gpios = <&gpio2 RK_PD7 GPIO_ACTIVE_HIGH>;
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_STATUS;
> +			label = "green:status";

The "label" property is deprecated.

> +&pcie2x1 {
> +	reset-gpios = <&gpio3 RK_PA4 GPIO_ACTIVE_HIGH>;

vpcie3v3-supply is missing.

> +	status = "okay";
> +};

> +&pcie3x1 {
> +	num-lanes = <1>;
> +	reset-gpios = <&gpio3 RK_PA3 GPIO_ACTIVE_HIGH>;

vpcie3v3-supply is missing.

> +	status = "okay";
> +};

> +&sdmmc0 {
> +	max-frequency = <150000000>;

max-frequency has been defined in rk356x-base.dtsi

> +	no-sdio;
> +	no-mmc;

no-mmc and cap-mmc-highspeed are mutually exclusive.

> +	bus-width = <4>;
> +	cap-mmc-highspeed;

> +/* Micro SD card slot is not populated */
> +/* Wifi module is not populated */

Why would you define them if they aren't on the board?

> +&sdmmc2 {
> +	max-frequency = <150000000>;

max-frequency has been defined in rk356x-base.dtsi

> +	bus-width = <4>;
> +	disable-wp;

disable-wp does not work with sdio

> +&usb2phy0_otg {

phy-supply is missing.

> +	status = "okay";
> +};