linux-kernel - Re: [PATCH] perf tools: Fix bool return value in gzip_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8c40795-a459-4218-ba78-24f057c53a51@linux.intel.com>
Date: Mon, 13 Oct 2025 18:27:58 +0800
From: "Mi, Dapeng" <dapeng1.mi@...ux.intel.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Miaoqian Lin <linmq006@...il.com>, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>,
 "Liang, Kan" <kan.liang@...ux.intel.com>, linux-perf-users@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] perf tools: Fix bool return value in gzip_is_compressed()


On 10/13/2025 5:16 PM, Namhyung Kim wrote:
> Hello,
>
> On Sat, Oct 11, 2025 at 11:48:56AM +0800, Mi, Dapeng wrote:
>> On 8/28/2025 6:46 PM, Miaoqian Lin wrote:
>>> gzip_is_compressed() returns -1 on error but is declared as bool.
>>> And -1 gets converted to true, which could be misleading.
>>> Return false instead to match the declared type.
>>>
>>> Fixes: 88c74dc76a30 ("perf tools: Add gzip_is_compressed function")
>>> Cc: <stable@...r.kernel.org>
>>> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
>>> ---
>>>  tools/perf/util/zlib.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/perf/util/zlib.c b/tools/perf/util/zlib.c
>>> index 78d2297c1b67..1f7c06523059 100644
>>> --- a/tools/perf/util/zlib.c
>>> +++ b/tools/perf/util/zlib.c
>>> @@ -88,7 +88,7 @@ bool gzip_is_compressed(const char *input)
>>>  	ssize_t rc;
>>>  
>>>  	if (fd < 0)
>>> -		return -1;
>>> +		return false;
>>>  
>>>  	rc = read(fd, buf, sizeof(buf));
>>>  	close(fd);
>> Reviewed-by: Dapeng Mi <dapeng1.mi@...ux.intel.com>
> We have 43fa1141e2c1af79 ("perf util: Fix compression checks returning -1
> as bool").

Good to know this has been fixed. Thanks. :)


>
> Thanks,
> Namhyung
>