linux-kernel - Re: [PATCH v2] spi: cadence-quadspi: Fix pm_runtime unbalance on dma EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o6qbujy1.fsf@kernel.org>
Date: Mon, 13 Oct 2025 13:20:38 +0200
From: Mattijs Korpershoek <mkorpershoek@...nel.org>
To: Mark Brown <broonie@...nel.org>, Mattijs Korpershoek
 <mkorpershoek@...nel.org>
Cc: Khairul Anuar Romli <khairul.anuar.romli@...era.com>, Dan Carpenter
 <dan.carpenter@...aro.org>, linux-spi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] spi: cadence-quadspi: Fix pm_runtime unbalance on
 dma EPROBE_DEFER

On Mon, Oct 13, 2025 at 11:22, Mark Brown <broonie@...nel.org> wrote:

> On Thu, Oct 09, 2025 at 09:10:38AM +0200, Mattijs Korpershoek wrote:
>> In csqspi_probe(), when cqspi_request_mmap_dma() returns -EPROBE_DEFER,
>> we handle the error by jumping to probe_setup_failed.
>> In that label, we call pm_runtime_disable(), even if we never called
>> pm_runtime_enable() before.
>
> This doesn't apply against current code, please check and resend.

Ah, sorry about that. I based this on master. I confirm it does not
apply on for-6.18.

Will resend shortly.