linux-kernel - Re: [PATCH v1] arm: mach-orion5x: ts78xx: simplify support configuration with table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e729b553-98bd-440d-a0e7-bd84448bd9d8@lunn.ch>
Date: Mon, 13 Oct 2025 14:14:27 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Alex Tran <alex.t.tran@...il.com>
Cc: alex@...riz.org.uk, sebastian.hesselbarth@...il.com,
	gregory.clement@...tlin.com, linux@...linux.org.uk,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] arm: mach-orion5x: ts78xx: simplify support
 configuration with table

On Sun, Oct 12, 2025 at 04:51:47PM -0700, Alex Tran wrote:
> Replace switch statement based configuration with a lookup table approach.
> The table is iterated through matching the correct configuration instead of
> setting the configuration on a case by case basis.

Is there anything actually wrong with the current code?

How did you test this?  Do you have a tx78xx?

The only changes made to this file in the last decade have been tree
wide changes. So unless you have one of these machines and intend to
add new features, i suggest you just leave this alone, it is just
needles churn to an ancient platform.

	Andrew