linux-kernel - Re: [PATCH -next] liveupdate: kho: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mafs05xcjm1pd.fsf@kernel.org>
Date: Mon, 13 Oct 2025 14:21:50 +0200
From: Pratyush Yadav <pratyush@...nel.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: graf@...zon.com,  rppt@...nel.org,  changyuanl@...gle.com,
  pasha.tatashin@...een.com,  kexec@...ts.infradead.org,
  linux-mm@...ck.org,  linux-kernel@...r.kernel.org,  Abaci Robot
 <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] liveupdate: kho: remove unneeded semicolon

On Mon, Oct 13 2025, Jiapeng Chong wrote:

> No functional modification involved.
>
> ./kernel/liveupdate/kexec_handover.c:1155:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=26158
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Looks like it comes from Pasha's series
https://lore.kernel.org/lkml/20251007033100.836886-4-pasha.tatashin@soleen.com/

I think this fix can be folded into the patch since it isn't merged yet.

> ---
>  kernel/liveupdate/kexec_handover.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> index 5da21f1510cc..c87d00c40c82 100644
> --- a/kernel/liveupdate/kexec_handover.c
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -1152,7 +1152,7 @@ static int __kho_finalize(void)
>  		err |= fdt_begin_node(root, fdt->name);
>  		err |= fdt_property(root, PROP_SUB_FDT, &phys, sizeof(phys));
>  		err |= fdt_end_node(root);
> -	};
> +	}
>  	mutex_unlock(&kho_out.fdts_lock);
>  
>  	err |= fdt_end_node(root);

-- 
Regards,
Pratyush Yadav