linux-kernel - Re: [PATCH v2] mmc: sdhci: Stop advertising the driver in dmesg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkda32Dw8sxkfDy9i19UP-59H-3WPNhffKLn+Pi7UgQ54vQ@mail.gmail.com>
Date: Mon, 13 Oct 2025 15:16:27 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Adrian Hunter <adrian.hunter@...el.com>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mmc: sdhci: Stop advertising the driver in dmesg

On Thu, Oct 9, 2025 at 8:11 AM Adrian Hunter <adrian.hunter@...el.com> wrote:
> On 08/10/2025 01:04, Linus Walleij wrote:
> > As much as we have grown used to seeing this message on
> > every kernel boot, it does not add any technical value.
> >
> > Drop all messages from sdhci_drv_init().
> >
> > We need to keep the module_init/exit() calls to stub
> > functions for the module to work according to
> > <linux/module.h>.
>
> But is that true?

I don't know, I don't have an SDHCI device at hand to test..

The comments say:

/* Each module must use one module_init(). */

And for module_exit():

/* This is only required if you want to be unloadable. */

If it's not true we need to fix the docs as well...

But I discussed it with Ulf in the office last week and he was
frantically testing out dropping it altogether.

Yours,
Linus Walleij