linux-kernel - Re: [PATCH RESEND v4 07/10] PM: EM: Implement em_nl_get_pd_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ddbe324-fc79-4ca6-8e9a-fdb3bef7dd3f@igalia.com>
Date: Mon, 13 Oct 2025 22:47:08 +0900
From: Changwoo Min <changwoo@...lia.com>
To: Lukasz Luba <lukasz.luba@....com>
Cc: christian.loehle@....com, tj@...nel.org, pavel@...nel.org,
 len.brown@...el.com, rafael@...nel.org, kernel-dev@...lia.com,
 linux-pm@...r.kernel.org, sched-ext@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v4 07/10] PM: EM: Implement
 em_nl_get_pd_table_doit()



On 10/10/25 19:01, Lukasz Luba wrote:
> 
> 
> On 9/21/25 04:19, Changwoo Min wrote:
>> When a userspace requests EM_CMD_GET_PD_TABLE with an ID of a 
>> performancei
> 
> s/performancei/performance/

Will fix it. Thanks!

[...]

>>   int em_nl_get_pd_table_doit(struct sk_buff *skb, struct genl_info 
>> *info)
>>   {
>> -    return -EOPNOTSUPP;
>> +    struct sk_buff *msg;
>> +    struct em_perf_domain *pd;
>> +    void *hdr;
>> +    int cmd = info->genlhdr->cmd;
>> +    int msg_sz, ret = -EMSGSIZE;
> 
> Please put them in the reverse christmas tree order.
> 

Sure, will fix it as suggested in the next version.

Regards,
Changwoo Min

> 
> After fixing that cosmetic thing you can add:
> 
> Reviewed-by: Lukasz Luba <lukasz.luba@....com>
>