linux-kernel - RE: [PATCH iwl-net v1] igc: fix race condition in TX timestamp read for register 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS1PR10MB5675DBFE7CE5F2A9336ABFA4EBEAA@AS1PR10MB5675.EURPRD10.PROD.OUTLOOK.COM>
Date: Mon, 13 Oct 2025 14:04:36 +0000
From: "Bouska, Zdenek" <zdenek.bouska@...mens.com>
To: Chwee-Lin Choong <chwee.lin.choong@...el.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Richard Cochran
	<richardcochran@...il.com>, Vinicius Costa Gomes <vinicius.gomes@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Avi Shalev
	<avi.shalev@...el.com>, Song Yoong Siang <yoong.siang.song@...el.com>
Subject: RE: [PATCH iwl-net v1] igc: fix race condition in TX timestamp read
 for register 0

On 18/09/2025 19:38, Chwee-Lin Choong wrote:
> This fix also prevents TX unit hangs observed under heavy
> timestamping load.
> 

I have tested this patch with heavy TX timestamps load.

I have not reproduced any hangs when I apply this patch to 6.15.0.

But when I apply it to 6.17.0, then I still have some hangs, but not as much as without the patch on 6.17.0.

Used git bisect with this patch and I found that this is the first commit where this patch does not avoid all hangs:

commit 0d58cdc902dace2298406b3972def04f55e3d775
Author: Faizal Rahim <faizal.abdul.rahim@...ux.intel.com>
Date:   Mon Mar 17 23:07:35 2025 -0400

    igc: optimize TX packet buffer utilization for TSN mode

    In preparation for upcoming frame preemption patches, optimize the TX
    packet buffer size. The total packet buffer size (RX + TX) is 64KB, with
    a maximum of 34KB for either RX or TX. Split the buffer evenly,
    allocating 32KB to each.

    For TX, assign 7KB to each of the four TX packet buffers (total 28KB)
    and reserve 4KB for BMC.

When I revert this commit and apply this patch on 6.17.0 I have no hangs.

Best regards,
Zdenek Bouska

--
Siemens, s.r.o
Foundational Technologies