linux-kernel - Re: [PATCH 1/2] arm: dts: ti: Adds device tree nodes for PRU Cores, IEP and eCAP modules of PRU-ICSS2 Instance.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8cfc5ece-6c2e-48d9-a65c-3edbcc9edc39@lunn.ch>
Date: Mon, 13 Oct 2025 16:44:16 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Parvathi Pudi <parvathi@...thit.com>
Cc: tony@...mide.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, richardcochran@...il.com,
	linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	danishanwar@...com, pratheesh@...com, prajith@...com,
	vigneshr@...com, praneeth@...com, srk@...com, rogerq@...com,
	krishna@...thit.com, mohan@...thit.com, pmohan@...thit.com,
	basharath@...thit.com, "Andrew F . Davis" <afd@...com>,
	Murali Karicheri <m-karicheri2@...com>
Subject: Re: [PATCH 1/2] arm: dts: ti: Adds device tree nodes for PRU Cores,
 IEP and eCAP modules of PRU-ICSS2 Instance.

> +				interrupt-names = "rx", "emac_ptp_tx",
> +								"hsr_ptp_tx";

Something looks wrong with the indentation here. The same happens in
at least one other place.

> +&pruss2_mdio {
> +	status = "okay";
> +	pruss2_eth0_phy: ethernet-phy@0 {
> +		reg = <0>;
> +		interrupt-parent = <&gpio3>;
> +		interrupts = <30 IRQ_TYPE_EDGE_FALLING>;
> +	};
> +
> +	pruss2_eth1_phy: ethernet-phy@1 {
> +		reg = <1>;
> +		interrupt-parent = <&gpio3>;
> +		interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
> +	};


PHY interrupts are 99% level, not edge, because they represent an
interrupt controller in the PHY, and you need to clear all the
interrupts in the controller before it deasserts the interrupt pin.

    Andrew

---
pw-bot: cr