linux-kernel - Re: [PATCH v2] arm64: dts: mediatek: mt8188-geralt: Enable first SCP core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b20a1c7d-0da5-433b-987c-f55a5a229bed@collabora.com>
Date: Tue, 14 Oct 2025 15:27:05 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Chen-Yu Tsai <wenst@...omium.org>,
 Matthias Brugger <matthias.bgg@...il.com>
Cc: linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Fei Shao <fshao@...omium.org>
Subject: Re: [PATCH v2] arm64: dts: mediatek: mt8188-geralt: Enable first SCP
 core

Il 14/08/25 11:25, Chen-Yu Tsai ha scritto:
> The first SCP core is used to drive the video decoder and encoders.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>
> ---
> Changes since v1:
> - Added SCP vreq pin
> ---
>   .../boot/dts/mediatek/mt8188-geralt.dtsi      | 25 +++++++++++++++++++
>   1 file changed, 25 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi
> index c5254ae0bb99..7fedbacdac44 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi
> @@ -164,6 +164,12 @@ reserved_memory: reserved-memory {
>   		#size-cells = <2>;
>   		ranges;
>   
> +		scp_mem_reserved: memory@...00000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0 0x50000000 0 0x800000>;
> +			no-map;
> +		};
> +
>   		apu_mem: memory@...00000 {
>   			compatible = "shared-dma-pool";
>   			reg = <0 0x55000000 0 0x1400000>;
> @@ -1077,6 +1083,13 @@ pins-bus {
>   		};
>   	};
>   
> +	scp_pins: scp-pins {
> +		pins-scp-vreq {
> +			pinmux = <PINMUX_GPIO98__FUNC_O_SCP_VREQ_VAO>;
> +			bias-disable;
> +		};
> +	};
> +
>   	spi0_pins: spi0-pins {
>   		pins-bus {
>   			pinmux = <PINMUX_GPIO69__FUNC_O_SPIM0_CSB>,
> @@ -1146,6 +1159,18 @@ &postmask0_out {
>   	remote-endpoint = <&dither0_in>;
>   };
>   
> +&scp_cluster {
> +	status = "okay";
> +};
> +
> +&scp_c0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&scp_pins>;
> +	firmware-name = "mediatek/mt8188/scp.img";

After a (very brief) discussion with Arnd last time, turns out we decided to avoid
using the firmware-name property, including for mtk-scp.

Please resend without firmware-name.

P.S.: there's a patch to construct the firmware name from compatible...
https://lore.kernel.org/r/20250911140043.190801-1-angelogioacchino.delregno@collabora.com

Cheers,
Angelo

> +	memory-region = <&scp_mem_reserved>;
> +	status = "okay";
> +};
> +
>   &sound {
>   	pinctrl-names = "aud_etdm_hp_on", "aud_etdm_hp_off",
>   			"aud_etdm_spk_on", "aud_etdm_spk_off",