linux-kernel - Re: [PATCH] staging: greybus: documentation: replace strncpy() with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aO5VvrKTswmfO-n9@stanley.mountain>
Date: Tue, 14 Oct 2025 16:53:02 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Vivek BalachandharTN <vivek.balachandhar@...il.com>
Cc: gregkh@...uxfoundation.org, johan@...nel.org, elder@...nel.org,
	schopin@...ntu.com, me@...y.me, greybus-dev@...ts.linaro.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: documentation: replace strncpy() with
 strscpy_pad()

On Tue, Oct 14, 2025 at 01:41:48PM +0000, Vivek BalachandharTN wrote:
> strncpy() does not guarantee NUL-termination and is deprecated for
> NUL-terminated strings. Replace it with strscpy_pad(), which guarantees
> NUL-termination and zero-pads the remaining bytes, matching the fixed-size
> firmware tag semantics.
> 
> Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@...il.com>
> ---
>  .../greybus/Documentation/firmware/firmware.c        | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c
> index 3b35ef6d4adb..deac8584841b 100644
> --- a/drivers/staging/greybus/Documentation/firmware/firmware.c
> +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c

This is sample user space code so the strscpy_pad() isn't available.  It
will break the compile.

regards,
dan carpenter