linux-kernel - Re: [PATCH net] gve: Check valid ts bit on RX descriptor before hw timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <willemdebruijn.kernel.18f9d84fb2f05@gmail.com>
Date: Tue, 14 Oct 2025 10:31:52 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Harshitha Ramamurthy <hramamurthy@...gle.com>, 
 netdev@...r.kernel.org
Cc: joshwash@...gle.com, 
 hramamurthy@...gle.com, 
 andrew+netdev@...n.ch, 
 davem@...emloft.net, 
 edumazet@...gle.com, 
 kuba@...nel.org, 
 pabeni@...hat.com, 
 willemb@...gle.com, 
 pkaligineedi@...gle.com, 
 jfraker@...gle.com, 
 ziweixiao@...gle.com, 
 thostet@...gle.com, 
 linux-kernel@...r.kernel.org, 
 stable@...r.kernel.org
Subject: Re: [PATCH net] gve: Check valid ts bit on RX descriptor before hw
 timestamping

Harshitha Ramamurthy wrote:
> From: Tim Hostetler <thostet@...gle.com>
> 
> The device returns a valid bit in the LSB of the low timestamp byte in
> the completion descriptor that the driver should check before
> setting the SKB's hardware timestamp. If the timestamp is not valid, do not

nit: weird line wrap. if setting had been on the line above, no line over 70.

> hardware timestamp the SKB.
> 
> Cc: stable@...r.kernel.org
> Fixes: b2c7aeb49056 ("gve: Implement ndo_hwtstamp_get/set for RX timestamping")
> Reviewed-by: Joshua Washington <joshwash@...gle.com>
> Signed-off-by: Tim Hostetler <thostet@...gle.com>
> Signed-off-by: Harshitha Ramamurthy <hramamurthy@...gle.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>