linux-kernel - RE: [PATCH v3 1/1] mm: prevent poison consumption when splitting THP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134373BFEC3E3F66D7BA39C89EBA@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Tue, 14 Oct 2025 14:51:12 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: David Hildenbrand <david@...hat.com>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "lorenzo.stoakes@...cle.com"
	<lorenzo.stoakes@...cle.com>, "linmiaohe@...wei.com" <linmiaohe@...wei.com>,
	"Luck, Tony" <tony.luck@...el.com>
CC: "ziy@...dia.com" <ziy@...dia.com>, "baolin.wang@...ux.alibaba.com"
	<baolin.wang@...ux.alibaba.com>, "Liam.Howlett@...cle.com"
	<Liam.Howlett@...cle.com>, "npache@...hat.com" <npache@...hat.com>,
	"ryan.roberts@....com" <ryan.roberts@....com>, "dev.jain@....com"
	<dev.jain@....com>, "baohua@...nel.org" <baohua@...nel.org>,
	"nao.horiguchi@...il.com" <nao.horiguchi@...il.com>, "Chen, Farrah"
	<farrah.chen@...el.com>, "jiaqiyan@...gle.com" <jiaqiyan@...gle.com>,
	"lance.yang@...ux.dev" <lance.yang@...ux.dev>, "richard.weiyang@...il.com"
	<richard.weiyang@...il.com>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 1/1] mm: prevent poison consumption when splitting THP

Hi David,

> From: David Hildenbrand <david@...hat.com>
> [...]
> > [ Credits to Andrew Zaborowski <andrew.zaborowski@...el.com> for his
> >    original fix that prevents passing the RMP_USE_SHARED_ZEROPAGE flag
> >    to remap_page() in Step[3] if the THP has the has_hwpoisoned flag set,
> >    avoiding access to the entire THP for zero-page identification. ]
> 
> Two smaller things:
> 
> (a) Sub-page is the wrong terminology. We simply call it "page in a THP". So
> consider changing multiple occurrence above.
> 
> (b) You should probably trim the credits to something simple like
> 
> 	"Thanks to Andrew Zaborowski for his initial work on fixing
>           this issue."
> 
> removing the brackets. If you want, you could then link to one of the
> submissions from him. The details how he would have fixed it are not really
> relevant to be had in this patch.
>

Thanks for the guidance. 
I'll create a v4 incorporating these suggestions.

> LGTM, thanks
> 
> Acked-by: David Hildenbrand <david@...hat.com>

Thanks for your review.

- Qiuxu