linux-kernel - Re: [PATCH v2] Update the USB option driver for the Rolling RW101R-GL modules.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aO5lpfmgGPGnbnvW@hovoldconsulting.com>
Date: Tue, 14 Oct 2025 17:00:53 +0200
From: Johan Hovold <johan@...nel.org>
To: Vanillan Wang <vanillanwang@....com>
Cc: gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Update the USB option driver for the Rolling
 RW101R-GL modules.

On Sun, Sep 28, 2025 at 05:28:23PM +0800, Vanillan Wang wrote:
> - VID:PID 33f8:0301, RW101R-GL for laptop debug M.2 cards(with MBIM
> interface for /Linux/Chrome OS)

> Signed-off-by: Vanillan Wang <vanillanwang@....com>
> ---

Thanks for the update, looks mostly good, but please use a succinct
commit summary (Subject) with the common prefix ("USB: serial: option:
add ...").

Also remember to include a short changelog here under the --- line when
respinning.

>  drivers/usb/serial/option.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index fc869b7f803f..98571e6b30da 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -2417,6 +2417,12 @@ static const struct usb_device_id option_ids[] = {
>  	  .driver_info = RSVD(5) },
>  	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0802, 0xff),			/* Rolling RW350-GL (laptop MBIM) */
>  	  .driver_info = RSVD(5) },
> +	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0301, 0xff) },			/* Rolling RW101R-GL (laptop MBIM) */
> +	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0302, 0xff) },			/* Rolling RW101R-GL (laptop MBIM) */
> +	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a8, 0xff),			/* Rolling RW101R-GL (laptop MBIM) */
> +	  .driver_info = RSVD(4) },
> +	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a9, 0xff),			/* Rolling RW101R-GL (laptop MBIM) */
> +	  .driver_info = RSVD(4) },

And try to keep the entries sorted by VID/PID.

>  	{ USB_DEVICE_AND_INTERFACE_INFO(0x3731, 0x0100, 0xff, 0xff, 0x30) },	/* NetPrisma LCUK54-WWD for Global */
>  	{ USB_DEVICE_AND_INTERFACE_INFO(0x3731, 0x0100, 0xff, 0x00, 0x40) },
>  	{ USB_DEVICE_AND_INTERFACE_INFO(0x3731, 0x0100, 0xff, 0xff, 0x40) },

Johan