linux-kernel - Re: [PATCH 1/8] firmware: imx: scu-irq: fix OF node leak in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aO5wtuMZILTYTBce@lizhi-Precision-Tower-5810>
Date: Tue, 14 Oct 2025 11:48:06 -0400
From: Frank Li <Frank.li@....com>
To: Peng Fan <peng.fan@....com>
Cc: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Dong Aisheng <aisheng.dong@....com>, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] firmware: imx: scu-irq: fix OF node leak in

On Tue, Oct 14, 2025 at 12:54:38PM +0800, Peng Fan wrote:
> imx_scu_enable_general_irq_channel() calls of_parse_phandle_with_args(),
> but does not release the OF node reference. Add a of_node_put() call
> to release the reference.
>
> Fixes: 851826c7566e ("firmware: imx: enable imx scu general irq function")
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---

Reviewed-by: Frank Li <Frank.Li@....com>

>  drivers/firmware/imx/imx-scu-irq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c
> index 6125cccc9ba79cd3445a720935b5c0b276c83d73..f2b902e95b738fae90af9cbe54da4f488219906f 100644
> --- a/drivers/firmware/imx/imx-scu-irq.c
> +++ b/drivers/firmware/imx/imx-scu-irq.c
> @@ -226,8 +226,10 @@ int imx_scu_enable_general_irq_channel(struct device *dev)
>  	INIT_WORK(&imx_sc_irq_work, imx_scu_irq_work_handler);
>
>  	if (!of_parse_phandle_with_args(dev->of_node, "mboxes",
> -				       "#mbox-cells", 0, &spec))
> +				       "#mbox-cells", 0, &spec)) {
>  		i = of_alias_get_id(spec.np, "mu");
> +		of_node_put(spec.np);
> +	}
>
>  	/* use mu1 as general mu irq channel if failed */
>  	if (i < 0)
>
> --
> 2.37.1
>