linux-kernel - Re: [PATCH 6/8] firmware: imx: scu: Update error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aO5zr3LnuZ9LHs9x@lizhi-Precision-Tower-5810>
Date: Tue, 14 Oct 2025 12:00:47 -0400
From: Frank Li <Frank.li@....com>
To: Peng Fan <peng.fan@....com>
Cc: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Dong Aisheng <aisheng.dong@....com>, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/8] firmware: imx: scu: Update error code

On Tue, Oct 14, 2025 at 12:54:43PM +0800, Peng Fan wrote:
> IMX_SC_ERR_NOTFOUND should map with -ENOENT, not -EEXIST. -ENODEV makes
> more sense for IMX_SC_ERR_NOPOWER, and -ECOMM makes more sense for
> IMX_SC_ERR_IPC.
>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---

Reviewed-by: Frank Li <Frank.Li@....com>

>  drivers/firmware/imx/imx-scu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
> index 8c28e25ddc8a650d2d191c40193cf1fb5e70bc35..6046156bc3c9abcd8f62b46f04571b1a9decc0eb 100644
> --- a/drivers/firmware/imx/imx-scu.c
> +++ b/drivers/firmware/imx/imx-scu.c
> @@ -73,9 +73,9 @@ static int imx_sc_linux_errmap[IMX_SC_ERR_LAST] = {
>  	-EACCES, /* IMX_SC_ERR_NOACCESS */
>  	-EACCES, /* IMX_SC_ERR_LOCKED */
>  	-ERANGE, /* IMX_SC_ERR_UNAVAILABLE */
> -	-EEXIST, /* IMX_SC_ERR_NOTFOUND */
> -	-EPERM,	 /* IMX_SC_ERR_NOPOWER */
> -	-EPIPE,	 /* IMX_SC_ERR_IPC */
> +	-ENOENT, /* IMX_SC_ERR_NOTFOUND */
> +	-ENODEV, /* IMX_SC_ERR_NOPOWER */
> +	-ECOMM,	 /* IMX_SC_ERR_IPC */
>  	-EBUSY,	 /* IMX_SC_ERR_BUSY */
>  	-EIO,	 /* IMX_SC_ERR_FAIL */
>  };
>
> --
> 2.37.1
>