| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20251014-bma220_events-v1-6-153424d7ea08@subdimension.ro>
Date: Tue, 14 Oct 2025 19:43:02 +0300
From: Petre Rodan <petre.rodan@...dimension.ro>
To: Jonathan Cameron <jic23@...nel.org>,
David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 6/6] iio: accel: bma220: add any-motion detection
Add support for what Bosch calls "any-motion (slope)" detection.
Signed-off-by: Petre Rodan <petre.rodan@...dimension.ro>
---
I think Jonathan remarked that this might be improper use of the iio API?
please advise.
---
drivers/iio/accel/bma220_core.c | 116 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 116 insertions(+)
diff --git a/drivers/iio/accel/bma220_core.c b/drivers/iio/accel/bma220_core.c
index f1d4646b495d..f79901ae8786 100644
--- a/drivers/iio/accel/bma220_core.c
+++ b/drivers/iio/accel/bma220_core.c
@@ -135,6 +135,13 @@ static const struct iio_event_spec bma220_events[] = {
BIT(IIO_EV_INFO_PERIOD) |
BIT(IIO_EV_INFO_HYSTERESIS),
},
+ {
+ .type = IIO_EV_TYPE_THRESH,
+ .dir = IIO_EV_DIR_EITHER,
+ .mask_separate = BIT(IIO_EV_INFO_ENABLE),
+ .mask_shared_by_type = BIT(IIO_EV_INFO_VALUE) |
+ BIT(IIO_EV_INFO_PERIOD),
+ },
};
#define BMA220_ACCEL_CHANNEL(index, reg, axis) { \
@@ -500,6 +507,34 @@ static int bma220_is_high_en(struct bma220_data *data,
return 0;
}
+static int bma220_is_slope_en(struct bma220_data *data,
+ enum iio_modifier axis,
+ bool *en)
+{
+ unsigned int reg_val;
+ int ret;
+
+ ret = regmap_read(data->regmap, BMA220_REG_IE0, ®_val);
+ if (ret)
+ return ret;
+
+ switch (axis) {
+ case IIO_MOD_X:
+ *en = FIELD_GET(BMA220_INT_EN_SLOPE_X_MSK, reg_val);
+ break;
+ case IIO_MOD_Y:
+ *en = FIELD_GET(BMA220_INT_EN_SLOPE_Y_MSK, reg_val);
+ break;
+ case IIO_MOD_Z:
+ *en = FIELD_GET(BMA220_INT_EN_SLOPE_Z_MSK, reg_val);
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
static int bma220_set_tap_en(struct bma220_data *data,
enum iio_modifier axis,
int type,
@@ -574,6 +609,34 @@ static int bma220_set_high_en(struct bma220_data *data,
return ret;
}
+static int bma220_set_slope_en(struct bma220_data *data, enum iio_modifier axis,
+ bool en)
+{
+ int ret;
+
+ switch (axis) {
+ case IIO_MOD_X:
+ ret = regmap_update_bits(data->regmap, BMA220_REG_IE0,
+ BMA220_INT_EN_SLOPE_X_MSK,
+ FIELD_PREP(BMA220_INT_EN_SLOPE_X_MSK, en));
+ break;
+ case IIO_MOD_Y:
+ ret = regmap_update_bits(data->regmap, BMA220_REG_IE0,
+ BMA220_INT_EN_SLOPE_Y_MSK,
+ FIELD_PREP(BMA220_INT_EN_SLOPE_Y_MSK, en));
+ break;
+ case IIO_MOD_Z:
+ ret = regmap_update_bits(data->regmap, BMA220_REG_IE0,
+ BMA220_INT_EN_SLOPE_Z_MSK,
+ FIELD_PREP(BMA220_INT_EN_SLOPE_Z_MSK, en));
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ return ret;
+}
+
static int bma220_read_event_config(struct iio_dev *indio_dev,
const struct iio_chan_spec *chan,
enum iio_event_type type,
@@ -618,6 +681,11 @@ static int bma220_read_event_config(struct iio_dev *indio_dev,
if (ret)
return ret;
return int_en;
+ case IIO_EV_DIR_EITHER:
+ ret = bma220_is_slope_en(data, chan->channel2, &int_en);
+ if (ret)
+ return ret;
+ return int_en;
default:
return -EINVAL;
}
@@ -662,6 +730,9 @@ static int bma220_write_event_config(struct iio_dev *indio_dev,
case IIO_EV_DIR_RISING:
ret = bma220_set_high_en(data, chan->channel2, state);
break;
+ case IIO_EV_DIR_EITHER:
+ ret = bma220_set_slope_en(data, chan->channel2, state);
+ break;
default:
return -EINVAL;
}
@@ -761,6 +832,25 @@ static int bma220_read_event_value(struct iio_dev *indio_dev,
default:
return -EINVAL;
}
+ case IIO_EV_DIR_EITHER:
+ switch (info) {
+ case IIO_EV_INFO_VALUE:
+ ret = regmap_read(data->regmap, BMA220_REG_CONF4,
+ ®_val);
+ if (ret)
+ return ret;
+ *val = FIELD_GET(BMA220_SLOPE_TH_MSK, reg_val);
+ return IIO_VAL_INT;
+ case IIO_EV_INFO_PERIOD:
+ ret = regmap_read(data->regmap, BMA220_REG_CONF4,
+ ®_val);
+ if (ret)
+ return ret;
+ *val = FIELD_GET(BMA220_SLOPE_DUR_MSK, reg_val);
+ return IIO_VAL_INT;
+ default:
+ return -EINVAL;
+ }
default:
return -EINVAL;
}
@@ -852,6 +942,25 @@ static int bma220_write_event_value(struct iio_dev *indio_dev,
default:
return -EINVAL;
}
+ case IIO_EV_DIR_EITHER:
+ switch (info) {
+ case IIO_EV_INFO_VALUE:
+ if (!FIELD_FIT(BMA220_SLOPE_TH_MSK, val))
+ return -EINVAL;
+ return regmap_update_bits(data->regmap,
+ BMA220_REG_CONF4,
+ BMA220_SLOPE_TH_MSK,
+ FIELD_PREP(BMA220_SLOPE_TH_MSK, val));
+ case IIO_EV_INFO_PERIOD:
+ if (!FIELD_FIT(BMA220_SLOPE_DUR_MSK, val))
+ return -EINVAL;
+ return regmap_update_bits(data->regmap,
+ BMA220_REG_CONF4,
+ BMA220_SLOPE_DUR_MSK,
+ FIELD_PREP(BMA220_SLOPE_DUR_MSK, val));
+ default:
+ return -EINVAL;
+ }
default:
return -EINVAL;
}
@@ -1023,6 +1132,13 @@ static irqreturn_t bma220_irq_handler(int irq, void *private)
IIO_EV_TYPE_THRESH,
IIO_EV_DIR_RISING),
timestamp);
+ if (FIELD_GET(BMA220_IF_SLOPE, bma220_reg_if1))
+ iio_push_event(indio_dev,
+ IIO_MOD_EVENT_CODE(IIO_ACCEL, 0,
+ IIO_MOD_X_OR_Y_OR_Z,
+ IIO_EV_TYPE_THRESH,
+ IIO_EV_DIR_EITHER),
+ timestamp);
if (FIELD_GET(BMA220_IF_TT, bma220_reg_if1)) {
if (data->tap_type == BMA220_TAP_TYPE_SINGLE)
--
2.49.1
Powered by blists - more mailing lists