linux-kernel - Re: [PATCH] PCI: rcar-host: Avoid objtool no-cfi warning in rcar_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251014174345.GA3062995@ax162>
Date: Tue, 14 Oct 2025 10:43:45 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
	Marek Vasut <marek.vasut+renesas@...il.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>, linux-pci@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev, kernel test robot <lkp@...el.com>,
	Kees Cook <kees@...nel.org>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: [PATCH] PCI: rcar-host: Avoid objtool no-cfi warning in
 rcar_pcie_probe()

On Tue, Oct 14, 2025 at 06:32:59PM +0530, Manivannan Sadhasivam wrote:
> TBH, I hate both of these CONFIG_OF checks as most of the controller drivers
> are just OF drivers. If we were to sprinkle CONFIG_OF check, then it has to be
> done in almost all controller drivers (except VMD, Hyper-V).
> 
> If compiler is getting smart enough to detect these NULL invocations, then it
> may start to trigger the same issue for other OF APIs as well. So I'd prefer to
> have the OF dependency in Kconfig, sacrificing COMPILE_TEST on non-OF configs.

Alright, fair enough. I will send a v2 soon just adding the dependency
on OF.

Cheers,
Nathan