linux-kernel - Re: [PATCH v3 0/2] Incorporate DRAM address in EDAC messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251014175238.GIaO6N5sWpG7EReE5P@fat_crate.local>
Date: Tue, 14 Oct 2025 19:52:38 +0200
From: Borislav Petkov <bp@...en8.de>
To: "Naik, Avadhut" <avadnaik@....com>,
	Yazen Ghannam <yazen.ghannam@....com>
Cc: Avadhut Naik <avadhut.naik@....com>, linux-edac@...r.kernel.org,
	john.allen@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/2] Incorporate DRAM address in EDAC messages

On Tue, Oct 14, 2025 at 12:13:36PM -0500, Naik, Avadhut wrote:
> > The "DRAM address" helps memory vendors analyze failures. System
> > builders want to collect this data and pass it along to the memory
> > vendors.

How real is such a use case? It sounds to me like wishful thinking and that no
one is going to use it in the end and we'll end up warming up the universe
with electrons needlessly...

> > The DRAM address is not contained in architectural data like
> > MCA info, and getting the address from MCA requires using additional
> > system-specific hardware info. It's much more reliable to get the DRAM
> > address from the system with the error rather than try to post-process
> > it later.

Ok, a bit better.

Now, why isn't that address part of the tracepoint so that system builders can
consume structured data instead of parsing scnprintf()-ed strings and trying
to guess what's there?

Also, some of the fields of TRACE_EVENT(mce_record already contain the fields
this set is adding - CS or so, for example. So there's redundancy already.

> If yes, will add this information to commit messages and resend.

When that happens, remove all text gunk which talks about what a patch does
- that should be visible from the diff.

And this is not the first time I'm saying this: folks, please stop explaining
the code.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette