linux-kernel - Re: [RFC PATCH 1/1] ovl: Use fsid as unique identifier for trusted origin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c0ebf78-d98a-4013-a54a-c528e06f7e9f@igalia.com>
Date: Tue, 14 Oct 2025 14:55:20 -0300
From: André Almeida <andrealmeid@...lia.com>
To: dsterba@...e.cz, Qu Wenruo <wqu@...e.com>
Cc: Christoph Hellwig <hch@...radead.org>, linux-kernel@...r.kernel.org,
 linux-btrfs@...r.kernel.org, linux-unionfs@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, kernel-dev@...lia.com,
 Miklos Szeredi <miklos@...redi.hu>, Amir Goldstein <amir73il@...il.com>,
 Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
 Anand Jain <anand.jain@...cle.com>,
 "Guilherme G . Piccoli" <gpiccoli@...lia.com>
Subject: Re: [RFC PATCH 1/1] ovl: Use fsid as unique identifier for trusted
 origin

On 10/14/25 14:40, David Sterba wrote:
> On Tue, Oct 14, 2025 at 03:43:54PM +1030, Qu Wenruo wrote:
>> 在 2025/10/14 15:09, Christoph Hellwig 写道:
>>> On Mon, Oct 13, 2025 at 10:57:07PM -0300, André Almeida wrote:
>>>> Some filesystem have non-persistent UUIDs, that can change between
>>>> mounting, even if the filesystem is not modified. To prevent
>>>> false-positives when mounting overlayfs with index enabled, use the fsid
>>>> reported from statfs that is persistent across mounts.
>>> Please fix btrfs to not change uuids, as that completely defeats the
>>> point of uuids.
>>>
>> That is the temp-fsid feature from Anand, introduced by commit
>> a5b8a5f9f835 ("btrfs: support cloned-device mount capability").
>>
>> I'm not 100% sure if it's really that important to support mounting
>> cloned devices in the first place, as LVM will reject activating any LVs
>> if there is even conflicting VGs names, not to mention conflicting UUIDs.
>>
>> If temp-fsid is causing problems with overlayfs, I'm happy to remove it,
>> as this really looks like a niche that no one is asking.
> What do you mean no one asking?  This was specifically asked for by
> Steam to do A/B root partition mounts for recovery. It is a niche use
> case but it has its users.
That's right, I've come across the issue reported here while working 
with SteamOS partitions, so it's being used. The original thread for 
this feature has more information about the use case: 
https://lore.kernel.org/linux-btrfs/20230504170708.787361-1-gpiccoli@igalia.com/