linux-kernel - Re: [PATCH][next] scsi: isci: Avoid -Wflex-array-member-not-at-end warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1wm4xb1wg.fsf@ca-mkp.ca.oracle.com>
Date: Tue, 14 Oct 2025 17:38:00 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        "Martin
 K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] scsi: isci: Avoid -Wflex-array-member-not-at-end
 warning


Gustavo,

> -Wflex-array-member-not-at-end was introduced in GCC-14, and we are
> getting ready to enable it, globally.
>
> Move the conflicting declaration (which happens to be in a union, so
> we're moving the entire union) to the end of the corresponding
> structure. Notice that `struct ssp_response_iu` is a flexible
> structure, this is a structure that contains a flexible-array member.
>
> With these changes fix the following warning:
>
> drivers/scsi/isci/task.h:92:11: warning: structure containing a
> flexible array member is not at the end of another structure
> [-Wflex-array-member-not-at-end]

Applied to 6.19/scsi-staging, thanks!

-- 
Martin K. Petersen