linux-kernel - Re: [PATCH 1/2] mmc: sdhci-of-dwcmshc: Add command queue support for rockchip SOCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251014214700.4182858-1-dsimic@manjaro.org>
Date: Tue, 14 Oct 2025 23:47:00 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: sebastian.reichel@...labora.com
Cc: adrian.hunter@...el.com,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	heiko@...ech.de,
	kernel@...labora.com,
	krzk+dt@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org,
	linux-rockchip@...ts.infradead.org,
	robh@...nel.org,
	ulf.hansson@...aro.org,
	yifeng.zhao@...k-chips.com
Subject: Re: [PATCH 1/2] mmc: sdhci-of-dwcmshc: Add command queue support for rockchip SOCs

Hello Sebastian,

> This adds CQE support for the Rockchip RK3588 and RK3576 platform. To
> be functional, the eMMC device-tree node must have a 'supports-cqe;'
> flag property.

> As the RK3576 devicet-tree has been upstreamed with the 'supports-cqe;'
> property set by default, the kernel already tried to use CQE, which
> results in system hang during suspend. This fixes the issue.

Thanks for the patch, it's great to see this implemented!  Please,
see a small nitpick below.

> +static void rk35xx_sdhci_cqe_enable(struct mmc_host *mmc)
> +{
[snip]
> +}
> +
> +static void rk35xx_sdhci_cqe_disabled(struct mmc_host *mmc, bool recovery)
> +{
[snip]
> +}

The function rk35xx_sdhci_cqe_disabled() should obviously be called
rk35xx_sdhci_cqe_disable() instead, i.e. it should use the standard
imperative mood...

> +static const struct cqhci_host_ops rk35xx_cqhci_ops = {
> +	.enable		= rk35xx_sdhci_cqe_enable,
> +	.disable	= rk35xx_sdhci_cqe_disabled,
> +	.dumpregs	= dwcmshc_cqhci_dumpregs,
> +	.set_tran_desc	= dwcmshc_set_tran_desc,
> +};

... which corresponds with the struct member names.