linux-kernel - Re: [PATCH][next] scsi: hisi_sas: Avoid a couple -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1frblb09r.fsf@ca-mkp.ca.oracle.com>
Date: Tue, 14 Oct 2025 18:19:25 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Yihang Li
 <liyihang9@...artners.com>,
        "James E.J. Bottomley"
 <James.Bottomley@...senpartnership.com>,
        "Martin K. Petersen"
 <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org, John
 Garry <john.g.garry@...cle.com>
Subject: Re: [PATCH][next] scsi: hisi_sas: Avoid a couple
 -Wflex-array-member-not-at-end warnings


Gustavo,

>>>           struct {
>>> -            struct ssp_command_iu task;
>>>               u32 prot[PROT_BUF_SIZE];
>>> +            struct ssp_command_iu task;
>>>           };
>
> Actually, I have a question here:
>
> is u32 prot[PROT_BUF_SIZE]; intended to overlap flex array
> task.add_cdb[] at some point?
>
> if not, this change is just fine. Otherwise, I'd need to update this
> patch to account for the overlap.

I am not familiar with the hisi hardware interface so I don't know
whether the overlap is intentional.

-- 
Martin K. Petersen