linux-kernel - Re: [PATCH] dt-bindings: watchdog: Convert marvell,orion-wdt to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJuSy34LLHwUZK=Bj+-Tak6Tj-CzU-9Ky+=9iUNBTO_iQ@mail.gmail.com>
Date: Tue, 14 Oct 2025 17:33:23 -0500
From: Rob Herring <robh@...nel.org>
To: Sander Vanheule <sander@...nheule.net>
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck <linux@...ck-us.net>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>, 
	Gregory Clement <gregory.clement@...tlin.com>, linux-watchdog@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: Convert marvell,orion-wdt to DT schema

On Tue, Oct 14, 2025 at 3:22 PM Sander Vanheule <sander@...nheule.net> wrote:
>
> Hi Rob,
>
> On Mon, 2025-10-13 at 16:31 -0500, Rob Herring (Arm) wrote:
> > -Clocks required for compatibles = "marvell,orion-wdt",
> > -                               "marvell,armada-370-wdt":
> > -- clocks : Must contain a single entry describing the clock input
> > -
> > -Clocks required for compatibles = "marvell,armada-xp-wdt"
> > -                               "marvell,armada-375-wdt"
> > -                               "marvell,armada-380-wdt":
> > -- clocks : Must contain an entry for each entry in clock-names.
> > -- clock-names : Must include the following entries:
> > -  "nbclk" (L2/coherency fabric clock),
> > -  "fixed" (Reference 25 MHz fixed-clock).
>
> > +  clocks:
> > +    minItems: 1
> > +    items:
> > +      - description: Reference 25 MHz fixed-clock supply.
> > +      - description: L2/coherency fabric clock input ("nbclk").
> > +
> > +  clock-names:
> > +    minItems: 1
> > +    items:
> > +      - const: nbclk
> > +      - const: fixed
>
> Shouldn't the "clock-names" items be in the same order as the "clocks" items?
> (With nbclk first)

Ah yes, I flipped the order of the names to match the .dts files, but
not clocks.

Also, I found there is a 2nd interrupt in some cases.

Rob